Fix crash in code action #7367
Closed
Fix crash in code action #7367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace `array<never, never>` as a way to detect empty arrays by a dedicated method
Support PHPStan notation for empty-arrays
…rison Simplify object comparison
Rename was_static property to is_static to be more accurate
Add explicit `resolveSymlinks` option for project directories
|
Ugh. This got really messed up ignore! |
|
Please branch off the 4.x branch. |
|
@weirdan did that in my newer pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bug introduced into codeAction as a result of the underlying cache being empty when creating new files while using the language server
It's actually almost the same as #7247 except I didn't add the try/catch to my own code! 🤕
Additionally this adds a quick speedup to
codeActionby adding a cache whenemitIssuesis called so that we don't have to run theIssueBuffereverytimecodeActionis called (which in vscode is a lot because every time the mouse or cursor moves a codeAction is sent). Instead we just ask the LanguageServer to give us the previous issues returned from IssueBuffer through the use of the methodgetCurrentIssues