Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Server Crash with Expecting non-empty $root_file_path and $checked_file_path #7246

Closed
tm1000 opened this issue Dec 30, 2021 · 0 comments

Comments

@tm1000
Copy link
Contributor

tm1000 commented Dec 30, 2021

See #7246 and psalm/psalm-vscode-plugin#107

Specifically if something crashes deep in Psalm we should try to catch most of these crashes in the language server and continue (if possible). This is one such instance where continuing is fine as the error comes from the result of live typing so the code completion (that is erroring) is wrong as the time of typing the letters.

This is really hard to actually give a code reproduction because it relies on Psalm having a live cache and then that cache changing while live typing. You can see this in the reference issue against psalm-vscode-plugin

See attached PR for resolution: #7247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants