Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.x build: configure prettier as formatter for json, yaml and markdown #1930

Merged
merged 2 commits into from
Sep 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changeset/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
"baseBranch": "master",
"updateInternalDependencies": "patch",
"ignore": []
}
}
52 changes: 26 additions & 26 deletions .changeset/pretty-hounds-tap.md
Original file line number Diff line number Diff line change
@@ -1,30 +1,30 @@
---
"@verdaccio/api": patch
"@verdaccio/auth": patch
"@verdaccio/cli": patch
"@verdaccio/dev-commons": patch
"@verdaccio/config": patch
"@verdaccio/commons-api": patch
"@verdaccio/file-locking": patch
"@verdaccio/htpasswd": patch
"@verdaccio/local-storage": patch
"@verdaccio/readme": patch
"@verdaccio/streams": patch
"@verdaccio/types": patch
"@verdaccio/hooks": patch
"@verdaccio/loaders": patch
"@verdaccio/logger": patch
"@verdaccio/logger-prettify": patch
"@verdaccio/middleware": patch
"@verdaccio/mock": patch
"@verdaccio/node-api": patch
"@verdaccio/proxy": patch
"@verdaccio/server": patch
"@verdaccio/store": patch
"@verdaccio/dev-types": patch
"@verdaccio/utils": patch
"verdaccio": patch
"@verdaccio/web": patch
'@verdaccio/api': patch
'@verdaccio/auth': patch
'@verdaccio/cli': patch
'@verdaccio/dev-commons': patch
'@verdaccio/config': patch
'@verdaccio/commons-api': patch
'@verdaccio/file-locking': patch
'@verdaccio/htpasswd': patch
'@verdaccio/local-storage': patch
'@verdaccio/readme': patch
'@verdaccio/streams': patch
'@verdaccio/types': patch
'@verdaccio/hooks': patch
'@verdaccio/loaders': patch
'@verdaccio/logger': patch
'@verdaccio/logger-prettify': patch
'@verdaccio/middleware': patch
'@verdaccio/mock': patch
'@verdaccio/node-api': patch
'@verdaccio/proxy': patch
'@verdaccio/server': patch
'@verdaccio/store': patch
'@verdaccio/dev-types': patch
'@verdaccio/utils': patch
'verdaccio': patch
'@verdaccio/web': patch
---

Enable prerelease mode with **changesets**
2 changes: 1 addition & 1 deletion .changeset/shiny-chefs-heal.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"@verdaccio/api": patch
'@verdaccio/api': patch
---

testing changesets
29 changes: 8 additions & 21 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,24 +1,11 @@
node_modules
**/fixtures/**
**/mock/store/**
**/partials/**
**/types/custom.d.ts
build/
coverage/
wiki/
static/
flow-typed/
node_modules/
static/
website/
build/
*.md
*.lock
*.yaml
Dockerfile
*.rpi
*.html
*.scss
*.png
*.json
*.name
*.tgz
*.jpg
*.sh
n4bb12 marked this conversation as resolved.
Show resolved Hide resolved
**/partials/**
**/fixtures/**
types/custom.d.ts
**/mock/store/**
wiki/
26 changes: 2 additions & 24 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,15 @@
"extends": [
"eslint:recommended",
"google",
"plugin:prettier/recommended",
"plugin:react/recommended",
"plugin:jest/recommended",
"plugin:@typescript-eslint/eslint-recommended",
"plugin:@typescript-eslint/recommended",
"plugin:import/typescript",
"plugin:jsx-a11y/recommended",
"prettier",
"prettier/react",
"prettier/@typescript-eslint"
"prettier"
],
"plugins": ["import", "jest", "jsx-a11y", "react-hooks", "prettier"],
"plugins": ["import", "jest", "jsx-a11y", "react-hooks"],
"env": {
"es6": true,
"node": true,
Expand All @@ -32,9 +29,6 @@
}
},
"settings": {
"react": {
"version": "detect"
},
"import/resolver": {
"node": {
"extensions": [".js", ".jsx", ".ts", ".tsx"]
Expand All @@ -44,22 +38,6 @@
"parser": "@typescript-eslint/parser",
"rules": {
"curly": ["error", "all"],
"prettier/prettier": [
2,
{
"useTabs": false,
"printWidth": 160,
"tabWidth": 2,
"singleQuote": true,
"bracketSpacing": true,
"jsxBracketSameLine": true,
"trailingComma": "es5",
"semi": true,
"parser": "typescript",
"importOrder": ["^@verdaccio/(.*)$", "^[./]"],
"importOrderSeparation": true
}
],
"react/prop-types": 0,
"jest/no-export": 0,
"jest/no-test-callback": 0,
Expand Down
15 changes: 10 additions & 5 deletions .github/ISSUE_TEMPLATE/bug.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@ labels: "issue: bug" "issue: needs triage"
---

**Describe the bug**

<!-- A clear and concise description of what the bug is. -->

**To Reproduce**

<!-- IMPORTANT:
- How to reproduce the issue
- Steps to reproduce the issue
Expand All @@ -16,26 +18,29 @@ Be aware, the lack of reproducible steps the issue might cause your ticket to be
-->

**Expected behavior**

<!-- A clear and concise description of what you expected to happen. -->

**Screenshots**

<!-- If applicable, add screenshots to help explain your problem. -->

**Configuration File (cat ~/.config/verdaccio/config.yaml)**

<!-- Please be careful do not leak any sensitive information, remove tokens -->

**Environment information**

<!-- Please paste the results of running `verdaccio --info` -->

**Debugging output**
- `$ NODE_DEBUG=request verdaccio` display request calls (verdaccio <--> uplinks)
- `$ DEBUG=express:* verdaccio` enable extreme verdaccio debug mode (verdaccio api)
- `$ npm -ddd` prints:
- `$ npm config get registry` prints:

- `$ NODE_DEBUG=request verdaccio` display request calls (verdaccio <--> uplinks)
- `$ DEBUG=express:* verdaccio` enable extreme verdaccio debug mode (verdaccio api)
- `$ npm -ddd` prints:
- `$ npm config get registry` prints:

<!--

IMPORTANT: please do not attach external files, all content should be visible from any device.
-->

8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/feature.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
name: "Feature Request 🔮"
name: 'Feature Request 🔮'
about: You want a feature request.
title: ""
labels: "topic: feature request"
assignees: ""
title: ''
labels: 'topic: feature request'
assignees: ''
---

<!--
Expand Down
24 changes: 11 additions & 13 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,21 @@

version: 2
updates:

# Maintain dependencies for GitHub Actions
- package-ecosystem: "github-actions"
directory: "/"
- package-ecosystem: 'github-actions'
directory: '/'
schedule:
interval: "weekly"
interval: 'weekly'

# Maintain dependencies for npm
- package-ecosystem: "npm"
directory: "/"
- package-ecosystem: 'npm'
directory: '/'
schedule:
interval: "daily"
allow:
- dependency-name: "@verdaccio/*"
- dependency-name: "verdaccio-*"
interval: 'daily'
allow:
- dependency-name: '@verdaccio/*'
- dependency-name: 'verdaccio-*'
assignees:
- "verdacciobot"
- 'verdacciobot'
labels:
- "bot: dependencies"

- 'bot: dependencies'
14 changes: 7 additions & 7 deletions .github/lock.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ lockLabel: false
lockComment: >
🤖This thread has been automatically locked 🔒 since there has not been
any recent activity after it was closed.

We lock tickets after 90 days with the idea to encourage you to open a ticket with new fresh data
and to provide you better feedback 🤝and better visibility 👀.

If you consider, you can attach this ticket 📨 to the new one as a reference for better context.

Thanks for being a part of the Verdaccio community! 💘
Expand All @@ -26,10 +26,10 @@ lockComment: >

# Optionally, specify configuration settings just for `issues` or `pulls`
issues:
exemptLabels:
- help-wanted
lockLabel: outdated
exemptLabels:
- help-wanted
lockLabel: outdated

pulls:
daysUntilLock: 90
lockLabel: outdated
daysUntilLock: 90
lockLabel: outdated
14 changes: 7 additions & 7 deletions .github/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@ exemptLabels:
- issue: bug
- dev: discuss
# Label to use when marking an issue as stale
staleLabel: issue: wontfix
staleLabel: 'issue: wontfix'
# Comment to post when marking an issue as stale. Set to `false` to disable
markComment: >
Hi pal 👋🏼!
Hi pal 👋🏼!

This issue has gone quiet 😶.
This issue has gone quiet 😶.

We get a lot of issues, so we currently close issues after 25 days of inactivity. It’s been at least 15 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add/suggest the label "discuss" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out [https://github.com/verdaccio/contributing](https://github.com/verdaccio/contributing) for more information about opening PRs, triaging issues, and contributing!
We get a lot of issues, so we currently close issues after 25 days of inactivity. It’s been at least 15 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add/suggest the label "discuss" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out [https://github.com/verdaccio/contributing](https://github.com/verdaccio/contributing) for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Verdaccio community! 💘
Thanks for being a part of the Verdaccio community! 💘
# Comment to post when closing a stale issue. Set to `false` to disable
closeComment: false
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ jobs:
run: npm i -g pnpm
- name: Install
run: pnpm recursive install
- name: Format
run: pnpm format:check
- name: Lint
run: pnpm lint
- name: Clean
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/docker-publish-pre-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ jobs:
run: npm run docker
env:
VERDACCIO_BUILD_REGISTRY: https://registry.verdaccio.org

# testVerdaccio:
# name: Test Verdaccio Publish
# runs-on: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
verdaccio-*.tgz
.DS_Store
build/
.eslintcache

### Test

Expand Down Expand Up @@ -33,4 +34,4 @@ website/public
website/.cache

# CI Pnpm cache
.pnpm-store/
.pnpm-store/
15 changes: 15 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
.cache/
**/corrupted-package/package.json
**/corrupted.json
**/invalid.js
**/invalid.json
**/pnpm-lock.yaml
**/verdaccio-corrupted.db.json
**/wrong.package.json
/website/.cache/
/website/crowdin/
/website/public/
/website/src/dictionaries/
CHANGELOG.md
CONTRIBUTORS.md
node_modules/
n4bb12 marked this conversation as resolved.
Show resolved Hide resolved
7 changes: 3 additions & 4 deletions website/.prettierrc.json → .prettierrc.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
{
"endOfLine": "auto",
"endOfLine": "lf",
n4bb12 marked this conversation as resolved.
Show resolved Hide resolved
"useTabs": false,
"printWidth": 180,
"printWidth": 160,
n4bb12 marked this conversation as resolved.
Show resolved Hide resolved
"tabWidth": 2,
"singleQuote": true,
"bracketSpacing": true,
"jsxBracketSameLine": true,
"trailingComma": "es5",
"semi": true,
"parser": "typescript"
n4bb12 marked this conversation as resolved.
Show resolved Hide resolved
"semi": true
}