New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.x build: configure prettier as formatter for json, yaml and markdown #1930

Merged

juanpicado merged 2 commits into 5.x from 5.x-configure-prettier-json-yml-md

Sep 3, 2020

Collaborator

n4bb12 commented Sep 1, 2020 •

edited

Based on #1928 (comment), here's the configuration for formatting json, yaml and markdown files.

Note: The CI jobs are intentionally failing.

This PR only contains the tooling changes. The formatting changes are excluded from this PR for better reviewability.

--> #1931 includes the formatting changes, where all jobs should be green.

n4bb12 force-pushed the 5.x-configure-prettier-json-yml-md branch from 26b7821 to 46dccda Compare

September 1, 2020 21:49

n4bb12 changed the title ~~build: configure pretter as formatt for most files~~ build: configure pretter as formatter for most files

n4bb12 force-pushed the 5.x-configure-prettier-json-yml-md branch from 46dccda to c2a1694 Compare

September 1, 2020 21:50

n4bb12 changed the title ~~build: configure pretter as formatter for most files~~ build: configure pretter as formatter for json, yaml and markdown

n4bb12 mentioned this pull request

5.x reformat code #1931

Merged

n4bb12 commented

View reviewed changes

package.json Show resolved Hide resolved

n4bb12 commented

View reviewed changes

CONTRIBUTORS.md Show resolved Hide resolved

n4bb12 commented

View reviewed changes

.prettierrc.json Show resolved Hide resolved

n4bb12 commented

View reviewed changes

.prettierrc.json Show resolved Hide resolved

n4bb12 commented

View reviewed changes

.eslintignore Show resolved Hide resolved

n4bb12 force-pushed the 5.x-configure-prettier-json-yml-md branch 2 times, most recently from 93e3618 to 1282213 Compare

September 1, 2020 22:18

DanielRuf changed the title ~~build: configure pretter as formatter for json, yaml and markdown~~ build: configure prettier as formatter for json, yaml and markdown

juanpicado reviewed

View reviewed changes

.prettierignore Show resolved Hide resolved

juanpicado reviewed

View reviewed changes

.prettierrc.json Show resolved Hide resolved

juanpicado reviewed

View reviewed changes

package.json Outdated Show resolved Hide resolved

juanpicado reviewed

View reviewed changes

package.json Outdated Show resolved Hide resolved

n4bb12 changed the title ~~build: configure prettier as formatter for json, yaml and markdown~~ 5.x build: configure prettier as formatter for json, yaml and markdown

n4bb12 force-pushed the 5.x-configure-prettier-json-yml-md branch 2 times, most recently from d7a6fc2 to 59c44a0 Compare

September 2, 2020 18:21


          build: configure pretter as formatter for most files

8c2f0dc

n4bb12 force-pushed the 5.x-configure-prettier-json-yml-md branch 3 times, most recently from 2f214e8 to 8c2f0dc Compare

September 2, 2020 18:45


          chore: reformat code (#1931)

ebd7ef6

* chore: re-format all files

* chore: force run quality anaylsis test

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

Member

juanpicado commented Sep 3, 2020 •

edited

I think you need to rebase this or remove the last ebd7ef6 commit, the other PR was already merged.

Collaborator Author

n4bb12 commented Sep 3, 2020

@juanpicado what do you mean? The other PR was based on this PR, so it's now all in here.

Member

juanpicado commented Sep 3, 2020

@juanpicado what do you mean? The other PR was based on this PR, so it's now all in here.

nevermind, I read wrong the changes.

juanpicado approved these changes

View reviewed changes

Member

juanpicado left a comment

Great !

juanpicado merged commit 3547179 into 5.x

delete-merged-branch bot deleted the 5.x-configure-prettier-json-yml-md branch

September 3, 2020 19:15

juanpicado added this to the 5.x.x milestone

juanpicado added this to In progress in Verdaccio Board (future release) via automation

juanpicado moved this from In progress to Review in progress in Verdaccio Board (future release)

juanpicado moved this from Review in progress to Done in Verdaccio Board (future release)

juanpicado added a commit that referenced this pull request


          build: configure prettier as formatter for json, yaml and markdown (#…

bfefd09

…1930)

* build: configure pretter as formatter for most files

* chore: reformat code (#1931)

* chore: re-format all files

* chore: force run quality anaylsis test

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

juanpicado added a commit that referenced this pull request


          build: configure prettier as formatter for json, yaml and markdown (#…

9654ffb

…1930)

* build: configure pretter as formatter for most files

* chore: reformat code (#1931)

* chore: re-format all files

* chore: force run quality anaylsis test

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

juanpicado added a commit that referenced this pull request


          build: configure prettier as formatter for json, yaml and markdown (#…

2c44c1e

…1930)

* build: configure pretter as formatter for most files

* chore: reformat code (#1931)

* chore: re-format all files

* chore: force run quality anaylsis test

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

juanpicado added a commit that referenced this pull request


          build: configure prettier as formatter for json, yaml and markdown (#…

9fb5169

…1930)

* build: configure pretter as formatter for most files

* chore: reformat code (#1931)

* chore: re-format all files

* chore: force run quality anaylsis test

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

juanpicado added a commit that referenced this pull request


          build: configure prettier as formatter for json, yaml and markdown (#…

537f586

…1930)

* build: configure pretter as formatter for most files

* chore: reformat code (#1931)

* chore: re-format all files

* chore: force run quality anaylsis test

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

juanpicado added a commit that referenced this pull request


          build: configure prettier as formatter for json, yaml and markdown (#…

ddb4243

…1930)

* build: configure pretter as formatter for most files

* chore: reformat code (#1931)

* chore: re-format all files

* chore: force run quality anaylsis test

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

juanpicado added a commit that referenced this pull request


          build: merge 6.x into master (#2178)

ba77f7a

* feat: migrate yarn workspaces (#1546)

* chore: update readme

* build(deps-dev): bump @octokit/rest from 16.28.9 to 17.0.0 (#1729)

Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 16.28.9 to 17.0.0.
- [Release notes](https://github.com/octokit/rest.js/releases)
- [Commits](octokit/rest.js@v16.28.9...v17.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* chore: reuse jest config

* chore: update dependencies

* refactor: utilities and auth

* refactor: fix imports

* refactor: fix import

* feat: remove support for allow_ prefix (#1741)

allow_access, allow_publish and proxy_access were supported as package access but this commit drop that support and ignore the properties

* build: publish Docker image to GitHub registry (5.x) (#1744)

* chore: test

* chore: test

* chore: test

* chore: test

* chore: test

* chore: test

* chore: test

* chore: restore previous check file

* build(deps): [security] bump acorn from 5.7.3 to 5.7.4 (#1752)

Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. **This update includes a security fix.**
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@5.7.3...5.7.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* chore: fix merge

* chore: re-enable coverage

* chore: disable test publish

* feat: migrate from buyan to pinojs (#1760)

* feat: migrate from buyan to pinojs

* chore: fix lint

* chore: release utils from import

* chore: fix test

* chore: add missing dep

* chore: add dependency

* chore: add prettifier module

* chore: add pretty stamp option

* chore: fix package name location

* chore: crash on try use rotating file type

* chore: remove arg

* build(deps): bump @verdaccio/readme from 9.3.0 to 9.5.0 (#1797)

Bumps [@verdaccio/readme](https://github.com/verdaccio/monorepo/tree/HEAD/core/readme) from 9.3.0 to 9.5.0.
- [Release notes](https://github.com/verdaccio/monorepo/releases)
- [Changelog](https://github.com/verdaccio/monorepo/blob/9.x/core/readme/CHANGELOG.md)
- [Commits](https://github.com/verdaccio/monorepo/commits/v9.5.0/core/readme)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* chore: update dependencies (maintenance)

* chore: update deps

* chore: update deps

* chore: fix dependencies

* chore: update deps

* chore: update deps

* chore: add types

* chore: update jest

* chore: website scaffolding   (#1843)

* chore: upload gatsby website

* chore: update header

* chore: add background header

* chore: add ci for website

* Update ci-website.yml

* chore: update patch mach ci

* chore: update ci settings

* chore: update docker version

* chore: update readme

* chore: remove duplication

* refactor: test api refactor (#1826)

* test: add test for whoami

* Update middleware.ts

* test for user api

* more test for user api

* remove repeated code

* refactor

* Update index.spec.ts

* add package test

refactor others

* chore: upgrade deps

* chore: add test for package

* chore: update test

* update lock file

* Update ci.yml

* Update ci.yml

* Update package.spec.ts

* chore: update ci settings

* chore: update deps

* chore: update test

* chore: update lock file

* chore: rebase from master

* refactor: devDependencies strictly defined in each package (#1884)

* refactor: new babel preset

* chore: using pnpm

let's see how it goes, all seems works fine by far, pretty solid.

* chore: update snapshot

* chore: update readme

* chore: lint prettier update (#1904)

* chore: update prettier@2.x

* chore: prettier auto fix

* chore: fake circleci

we don't need it but I want make dissapear the error

* chore: extend lint rules to root

* chore: ignore codeql analysis

I shutdown this temporary while is in development

* chore: update branch for ci

* feat: relocate core packages (#1906)

* chore: clean lint warnings

* refactor: move core packages

* feat: add @verdaccio/commons-api package

Update local references

* chore: update wrong imports

* chore: update typescript and lint plugins

* feat: improve workspace and dependencies debug

* feat: using workspace @verdaccio/types

* feat: use core local-storage plugin

* chore: add missing dependencies

* chore: replace trace by debug

* chore: plugin loader uses debug

* feat: enable changesets (#1913)

* chore: add changeset deps

* chore: enable prerelease mode

* enable changesets

* chore: add changesets workflow

* chore: update changesets workflow

* chore: update changesets workflow

* chore: update changesets workflow

* chore add run-s dependency

* chore: install right dep npm-run-all

* chore: add missing script

* chore: ci include release pr

* chore: ignore pnpm store

* reenable docker publish

* chore: restore website build (#1920)

* 5.x tests on windows (#1919)

* build: add missing os matrix (#1928)

* chore: patch changesets example (#1929)

* chore: test changesets

* chore: add changeset

* chore: downgrade pnpm changeset workflow

* build: configure prettier as formatter for json, yaml and markdown (#1930)

* build: configure pretter as formatter for most files

* chore: reformat code (#1931)

* chore: re-format all files

* chore: force run quality anaylsis test

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

Co-authored-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

* feat: add typescript project references settings (#1933)

Add two different settings for compile and develop.

https://www.typescriptlang.org/docs/handbook/project-references.html

* docs: update contribution guidelines, scripts to debug and additional notes (#1918)

* chore: debug improments

* update guides

* docs: update contribution guidelines

* chore: add debug notest

* chore: format code

* chore: prepare website for development (#1935)

* chore: fix missing dependencies

* clean index page and sidebar

* improve layout for doc page

* format

* basic layout

* Update what-is-verdaccio.md

* check format

* chore: website drawer for navigation (#1940)

* feat(website): add drawer navigation

* chore: create index by language

* Update Header.tsx

* refactor: max-len and printWidth to 100 (#1941)

* refactor: max-len and printWidth to 100

* chore: ci specific pnpm version

* fix: add types peer package

literally get rid of types package

* refactor: migrate request to node-fetch at hooks package (#1946)

* refactor(hooks): new structure for notifications

* chore: fix build

* chore: add debug

* chore: add changeset

* chore: update dev deps (#1950)

* refactor: auth-utils (#1951)

* chore: refactor auth utils

* chore: relocate crypto utils

* fix urls in some packages/*/package.json (#1952)

* feat: improve legacy token signature by removing deprecated crypto.cr… (#1953)

* feat: improve legacy token signature by removing deprecated crypto.createDecipher

* fix: wrong reference

* chore: add debug

* fix: improving typescript practices in `packages/web/src/endpoint/package.ts` (#1972)

* chore: 1. Remove @ts-ignore, 2. Remove :any and infer from existed lib, 3. Prevent variable re-assign

* chore: add changeset

* refactor: relocate verdaccio-memory plugin (#1974)

* refactor: relocate verdaccio-auth-memory plugin (#1975)

* refactor: relocate verdaccio-audit plugin (#1976)

* refactor: relocate verdaccio-aws-storage plugin (#1977)

* fix: eslint errors (#1973)

* fix: eslint errors

* fix: rename a test

* fix: broken integration test

due to removing next argument in the middleware.

* changeset

* fix: typos and toc (#1980)

* updated table of content
* corrected spelling and grammar in a few places
* header levels

* refactor: relocate verdaccio-google-cloud-storage plugin (#1978)

* refactor: relocate verdaccio-active-directory plugin (#1981)

* fix: cleanup warnings (#1986)

* fix: lint warnings

* fix: test

* docs: relocate docker-examples to 5.x (#1990)

* docs: relocate docker-examples to 5.x

* chore: update readme

* chore: remove license

we have already one at root

* chore: disable rules for examples

* refactor: config module (#1995)

* refactor: clean up config

* refactor: config, move methods

* chore: remove js-yaml from utils

* chore: update versions

* refactor: config module, experiments renamed to flags (#1996)

* refactor: config security refactor

* chore: add changeset

* chore: rename self_path to config_path on test

* chore: fix test

* chore: remove self_path on init

* chore: add missing dependency

* feat: logger pretty only as dev mode (#1999)

* deps: update typescript 4 (#2000)

* chore: remove a package, move constants (#2001)

* chore: remove a package, move constants

* chore: remove *

* chore: update pnpm changeset action

* chore: update pnpm changeset versions (#2002)

* chore: update lock file

* chore: update lock file

* chore: verdaccio as root dependency to avoid changesets override

* chore: update versions (alpha) (#1916)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* enable CLI E2e on 5.x (#2011)

* test: enable e2e

* test: improve setup

* chore: update setup

* test: publish on temp folder

* chore: initial setup example

* chore: add global install to pnpm

* chore: update test script

* test: add info command

* chore: add install tests

* chore: add debug enabled code

* chore: update pnpm lock file

* feat: ui theme on 5.x (#2033)

* refactor: relocate theme-ui as plugin

* refactor: relocate theme-ui as plugin

* refactor: relocate theme-ui as plugin

* chore: fix lint

* chore: add missing folder

* refactor: relocate theme-ui as plugin

* refactor: relocate theme-ui as plugin

* refactor: relocate theme-ui as plugin

* chore: update scripts

* refactor: relocate theme-ui as plugin

* refactor: relocate theme-ui as plugin

* refactor: relocate theme-ui as plugin

* refactor: relocate theme-ui as plugin

* refactor: enable e2e for UI (#2036)

* refactor: enable e2e for UI

* refactor: enable e2e for UI

* refactor: enable e2e for UI

* refactor: enable e2e for UI

* refactor: enable e2e for UI

* refactor: enable e2e for UI

* chore: fix gatsby cloud build (#2037)

* build: server reload watch mode (#2039)

* feat: server reload watch mode

* chore:update format

* chore: update versions (alpha) (#2035)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: update readme

* chore: format document

* chore: update snapshot

* chore: testing publish docker image

* fix: docker build missing modules (#2041)

* chore: update docker publish config

* feat: remove level dependency by lowdb for npm token cli as storage (#2043)

* feat: remove level for token by lowdb

* chore: fix format

* chore: fix config

* chore: add changeset

* chore: update versions (alpha) (#2045)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: add rate limit to all request (#2050)

* feat: add rate limit to all request

* chore: increase max

* chore: update settings

* chore: deprecate keepAliveTimeout

* chore: update versions (alpha) (#2051)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* build: release scripts alpha packages (#2052)

* chore: update deps

* chore: update deps

* chore: update versions (alpha) (#2053)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: update log

* chore: add extra env var

* chore: add registry field

* chore: update script

* chore: update npmrc

* chore: update deps (#2056)

* chore: update deps

* chore: update eslint

* chore: update deps types

* feat: standalone server (#2046)

* feat: standalone version

* chore: add changeset

* chore: update versions (alpha) (#2057)

* chore: update readme

* feat: allow other password hashing algorithms (#1917) (#2072)

* chore: update versions (alpha) (#2073)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* ref: refactor utils methods (#2076)

* ref: Relocate utils functions to web pkg

* ref: Refactor utils functions

* ref: Relocate utils functions to api pkg

* ref: Relocate utils functions to config pkg

* ref: Relocate utils functions to middleware pkg

* ref: Relocate utils functions to storage pkg

* ref: relocate utils functions to proxy pkg

* ref: relocate utils functions to middleware pkg

* ref: refactor utils functions

* Fix compilation errors

* chore: update package.json and README.md (#2090)

* Improve package.json metadata (#2091)

* chore: update babel.js version (#2092)

* chore: update Dependencies (#2093)

* Update dependencies

* Update dist-tags.ts

* Update dist-tags.ts

* chore: update eslint dependency (#2094)

* chore: update pnpm (#2095)

* feat: improve cli logging on start up (#2097)

* feat: improve cli logging on start up

* chore: remove deps

* chore: update versions (alpha) (#2098)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: flexible user interface generator (#2070)

* feat: flexible template generator and manifest

* chore: add changeset

* chore: restore dep

* chore: add docs

* chore: update snapshots

* chore: update docker examples for v5

* chore: refactor web module

* chore: format

* chore: refactor web api endpoints

* test: add test for user login web

* chore: refactor endpoints

* chore: fix merge

* chore: fix merge

* Update ci.yml

* chore: test

* chore: add static

* chore: update script

* chore: fix e2e

* chore: fix method

* docs: update v5 relative docker example

* chore: update html render

* chore: update style

* Update .prettierignore

* chore: update changeset

* chore: use pnpm6 on run test

temporary ci

* chore: drop node 16 for pnpm 6

* chore: update ci

* chore: update ci

* chore: update ci

* chore: update ci

* chore: remove circle ci

* chore: better url prefix handling

* chore: format code

* chore: remove test node 10

* docs: add docker v5 relative revers proxy example

* chore: use base html tag

* chore: update test

* chore: update versions (alpha) (#2116)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: merge from master

* chore: update format

* chore: formmat code

* chore: update to 6.x

* chore: update docker publish next

* chore: update ci branch docker publish

* feat!: async storage plugin bootstrap (#2144)

* feat: async storage plugin bootstrap

* refactor fs.promise to promisify on node12

* Add changeset

* Update big-lobsters-sin.md

* Update utils.test.ts

* Update utils.test.ts

* Update ci.yml

* Update utils.test.ts

* Migrate fs-memory library to memfs (#2149)

* Update package.json

* Update MemoryFileSystem dependency

* Update storage.ts

* chore: update with master (#2158)

* feat: use clipanion over commander (#2159)

* feat: use clipanion over commander

* chore: update

* chore: add missing options

* chore: fix arguments

* chore: format code

* chore: update

* chore: fix missing node conf

* chore: add version

* Update setup.ts

* chore: fix config flag

* chore: add changeset

* chore: update versions

* chore: fix changeset

* chore: fix format

* chore: fix lint

* chore: add missing dep

* chore: remove unused code

* chore: update versions (6-next) (#2162)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: update env

* feat: improve node-api (#2165)

* refactor: improve node-api

* chore: add test for run server

* chore: update versions (6-next) (#2166)

* chore: add update-ts-references (#2168)

* chore: add update-ts-references

* chore: update version

* chore: update pnpm 6 lock file

* -chore: fix website ci

* chore: fix ci web

* chore: fix web ci

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Abraham Schilling <AbrahamSchilling@gmail.com>
Co-authored-by: mknj <github@mknj.de>
Co-authored-by: ike <ike.chang@sideeffect.dev>
Co-authored-by: Dina Basumatary <dnafication@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Slava <slovaricheg@gmail.com>
Co-authored-by: Paola Morales <dianmorales@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment