Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade styled-jsx with precompiled dist #33319

Closed
wants to merge 1 commit into from

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 14, 2022

x-ref: vercel/styled-jsx#770

Related: #31887

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 14, 2022
@ijjk
Copy link
Member

ijjk commented Jan 14, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js update-styled-jsx Change
buildDuration 18.8s 19s ⚠️ +273ms
buildDurationCached 4.3s 4.2s -130ms
nodeModulesSize 355 MB 354 MB -999 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js update-styled-jsx Change
/ failed reqs 0 0
/ total time (seconds) 4.096 4.03 -0.07
/ avg req/sec 610.33 620.33 +10
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.044 1.968 -0.08
/error-in-render avg req/sec 1223.16 1270.27 +47.11
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js update-styled-jsx Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js update-styled-jsx Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js update-styled-jsx Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.7 kB 4.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js update-styled-jsx Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js update-styled-jsx Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js update-styled-jsx Change
buildDuration 21s 21s ⚠️ +21ms
buildDurationCached 4.2s 4.2s ⚠️ +2ms
nodeModulesSize 355 MB 354 MB -999 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js update-styled-jsx Change
/ failed reqs 0 0
/ total time (seconds) 3.993 4.019 ⚠️ +0.03
/ avg req/sec 626.04 621.98 ⚠️ -4.06
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.081 1.984 -0.1
/error-in-render avg req/sec 1201.24 1260.36 +59.12
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js update-styled-jsx Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js update-styled-jsx Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js update-styled-jsx Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js update-styled-jsx Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js update-styled-jsx Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 2c1a7b5

@huozhi huozhi marked this pull request as ready for review January 14, 2022 16:47
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got this updated in #32742 to track the ncc changes together

@huozhi huozhi closed this Jan 14, 2022
@huozhi huozhi deleted the update-styled-jsx branch January 14, 2022 16:52
@vercel vercel locked as resolved and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants