Pre-compile more dependencies #32742

ijjk · 2021-12-22T19:57:29Z

This ncc's some remaining dependencies bringing us under 20 install time dependencies (including nested dependencies), this also reduces install size by another 2.75 MB. A follow-up PR will investigate a custom install script for our swc packages to allow us to remove the optionalDependencies which is slowing down install time as well.

x-ref: #32679
x-ref: #32627
x-ref: #31887
x-ref: vercel/styled-jsx#770

# Conflicts: # packages/next/build/webpack-config.ts

# Conflicts: # packages/next/package.json

ijjk · 2022-01-17T15:07:28Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
buildDuration	14.6s	14.7s	⚠️ +86ms
buildDurationCached	3.3s	3.2s	-56ms
nodeModulesSize	355 MB	352 MB	-2.75 MB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.918	2.984	⚠️ +0.07
/ avg req/sec	856.62	837.76	⚠️ -18.86
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.352	1.373	⚠️ +0.02
/error-in-render avg req/sec	1849.16	1820.67	⚠️ -28.49

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27.2 kB	27.2 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71 kB	71 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.7 kB	4.7 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.13 kB	2.13 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Diffs

Diff for main-HASH.js

@@ -911,7 +911,9 @@
                       }
                       isValidElementType = Object(
                         (function webpackMissingModule() {
-                          var e = new Error("Cannot find module 'react-is'");
+                          var e = new Error(
+                            "Cannot find module 'next/dist/compiled/react-is'"
+                          );
                           e.code = "MODULE_NOT_FOUND";
                           throw e;
                         })()
@@ -5696,7 +5698,7 @@
                               isValidElementType = Object(
                                 (function webpackMissingModule() {
                                   var e = new Error(
-                                    "Cannot find module 'react-is'"
+                                    "Cannot find module 'next/dist/compiled/react-is'"
                                   );
                                   e.code = "MODULE_NOT_FOUND";
                                   throw e;

Diff for index.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b72ca22dbd9e018c.js"
+      src="/_next/static/chunks/main-ff67cafd595aae95.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b72ca22dbd9e018c.js"
+      src="/_next/static/chunks/main-ff67cafd595aae95.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b72ca22dbd9e018c.js"
+      src="/_next/static/chunks/main-ff67cafd595aae95.js"
       defer=""
     ></script>
     <script

Default Build with SWC (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
buildDuration	15.9s	15.6s	-308ms
buildDurationCached	3.3s	3.2s	-129ms
nodeModulesSize	355 MB	352 MB	-2.75 MB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.956	2.925	-0.03
/ avg req/sec	845.75	854.57	+8.82
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.339	1.344	⚠️ +0.01
/error-in-render avg req/sec	1866.63	1860.24	⚠️ -6.39

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	27.3 kB	27.3 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.3 kB	71.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.36 kB	2.36 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	911 B	911 B	✓
image-HASH.js gzip	4.73 kB	4.73 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js update/finish-nccing	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Diffs

Diff for main-HASH.js

@@ -911,7 +911,9 @@
                       }
                       isValidElementType = Object(
                         (function webpackMissingModule() {
-                          var e = new Error("Cannot find module 'react-is'");
+                          var e = new Error(
+                            "Cannot find module 'next/dist/compiled/react-is'"
+                          );
                           e.code = "MODULE_NOT_FOUND";
                           throw e;
                         })()
@@ -5696,7 +5698,7 @@
                               isValidElementType = Object(
                                 (function webpackMissingModule() {
                                   var e = new Error(
-                                    "Cannot find module 'react-is'"
+                                    "Cannot find module 'next/dist/compiled/react-is'"
                                   );
                                   e.code = "MODULE_NOT_FOUND";
                                   throw e;

Diff for index.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b72ca22dbd9e018c.js"
+      src="/_next/static/chunks/main-ff67cafd595aae95.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b72ca22dbd9e018c.js"
+      src="/_next/static/chunks/main-ff67cafd595aae95.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b72ca22dbd9e018c.js"
+      src="/_next/static/chunks/main-ff67cafd595aae95.js"
       defer=""
     ></script>
     <script

Commit: 07da242

This ncc's some remaining dependencies bringing us under 20 install time dependencies (including nested dependencies), this also reduces install size by another `2.75 MB`. A follow-up PR will investigate a custom install script for our swc packages to allow us to remove the `optionalDependencies` which is slowing down install time as well. x-ref: vercel#32679 x-ref: vercel#32627 x-ref: vercel#31887 x-ref: vercel/styled-jsx#770

ijjk added 2 commits December 22, 2021 13:56

re-ncc stream-browserify and copy react-is

70822ed

update compiled

0372b11

ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Dec 22, 2021

This comment has been minimized.

Sign in to view

ijjk added 5 commits December 22, 2021 15:19

ncc styled-jsx

9cd3118

update compiled

8a89229

Update externals for styled-jsx

4a3b672

update compiled

eb80628

fix-lint

cc0bed7

This comment has been minimized.

Sign in to view

ijjk added 5 commits January 12, 2022 14:26

Merge branch 'canary' into update/finish-nccing

4ba8c30

# Conflicts: # packages/next/build/webpack-config.ts

revert nccing styled-jsx from conflict

83d3379

update compiled

4a627cb

re-add dep

8398a50

remove more styled-jsx changes

dcdd520

This comment has been minimized.

Sign in to view

ijjk added 4 commits January 13, 2022 19:45

ncc jest-worker

d03d951

update compiled

c7a378e

Merge branch 'canary' into update/finish-nccing

f4b0297

# Conflicts: # packages/next/package.json

add missing test dep

999e618

This comment has been minimized.

Sign in to view

ijjk added 2 commits January 13, 2022 21:11

copy react-refresh-utils

eb0a940

update compiled

fdced7d

ijjk mentioned this pull request Jan 14, 2022

perf: Pre-compile dependencies to reduce install size/time vercel/styled-jsx#770

Merged

ijjk added 3 commits January 13, 2022 21:37

fix lint

f0821ab

ncc node-fetch

6327493

update compiled

aa28643

This comment has been minimized.

Sign in to view

Update to pre-compiled styled-jsx version

903e891

This comment has been minimized.

Sign in to view

ijjk marked this pull request as ready for review January 14, 2022 16:53

ijjk requested review from huozhi, padmaia, shuding and timneutkens as code owners January 14, 2022 16:53

ijjk requested a review from styfle January 14, 2022 16:53

ijjk added 2 commits January 14, 2022 11:17

Merge branch 'canary' into update/finish-nccing

e616d6d

Merge branch 'canary' into update/finish-nccing

37e8169

This comment has been minimized.

Sign in to view

styfle approved these changes Jan 14, 2022

View reviewed changes

timneutkens approved these changes Jan 17, 2022

View reviewed changes

Merge branch 'canary' into update/finish-nccing

07da242

kodiakhq bot merged commit 25d064f into vercel:canary Jan 17, 2022

ijjk deleted the update/finish-nccing branch January 17, 2022 15:58

This was referenced Jan 19, 2022

Missing peerDependency "@babel/core@^7.0.0-0" from next > styled-jsx > @babel/plugin-syntax-jsx@7.14.5 #31887

Closed

Missing @babel/core dependency vercel/styled-jsx#736

Closed

vercel locked as resolved and limited conversation to collaborators Feb 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pre-compile more dependencies #32742

Pre-compile more dependencies #32742

ijjk commented Dec 22, 2021 •

edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jan 17, 2022

Diffs

Diffs

Pre-compile more dependencies #32742

Pre-compile more dependencies #32742

Conversation

ijjk commented Dec 22, 2021 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jan 17, 2022

Stats from current PR

Diffs

Diffs

ijjk commented Dec 22, 2021 •

edited