Upgrade chalk 4.0.0 #11268

matamatanot · 2020-03-22T02:31:06Z

Change import way (esModuleInterop setting is enabled. )

-import chalk from 'chalk';
+import * as chalk from 'chalk';

ijjk · 2020-03-22T04:22:48Z

Failing test suites

test/integration/app-document-style-fragment/test/index.test.js

Custom Document Fragment Styles > correctly adds styles from fragment styles key

Expand output

● Custom Document Fragment Styles › correctly adds styles from fragment styles key

Could not find a valid build in the '/home/runner/work/next.js/next.js/test/integration/app-document-style-fragment/.next' directory! Try building your app with 'next build' before starting the server.

  889 |         catch (err) {
  890 |             if (!fs_1.default.existsSync(buildIdFile)) {
> 891 |                 throw new Error(`Could not find a valid build in the '${this.distDir}' directory! Try building your app with 'next build' before starting the server.`);
      |                       ^
  892 |             }
  893 |             throw err;
  894 |         }

  at Server.readBuildId (../packages/next/dist/next-server/server/next-server.js:891:23)
  at new Server (../packages/next/dist/next-server/server/next-server.js:53:29)
  at createServer (../packages/next/dist/server/next.js:2:133)
  at Object.<anonymous> (integration/app-document-style-fragment/test/index.test.js:22:11)

● Custom Document Fragment Styles › correctly adds styles from fragment styles key

FetchError: request to http://localhost/:undefined/ failed, reason: connect ECONNREFUSED 127.0.0.1:80

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

test/integration/auto-export-query-error/test/index.test.js

Auto Export > server mode > should show warning for query provided for auto exported page correctly
Auto Export > serverless mode > should show warning for query provided for auto exported page correctly

Expand output

● Auto Export › server mode › should show warning for query provided for auto exported page correctly

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 0

  14 | const runTests = () => {
  15 |   it('should show warning for query provided for auto exported page correctly', async () => {
> 16 |     expect(exitCode).toBe(1)
     |                      ^
  17 |     expect(stderr).toContain(
  18 |       'Error: you provided query values for / which is an auto-exported page. These can not be applied since the page can no longer be re-rendered on the server. To disable auto-export for this page add `getInitialProps`'
  19 |     )

  at Object.<anonymous> (integration/auto-export-query-error/test/index.test.js:16:22)

● Auto Export › serverless mode › should show warning for query provided for auto exported page correctly

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 0

  14 | const runTests = () => {
  15 |   it('should show warning for query provided for auto exported page correctly', async () => {
> 16 |     expect(exitCode).toBe(1)
     |                      ^
  17 |     expect(stderr).toContain(
  18 |       'Error: you provided query values for / which is an auto-exported page. These can not be applied since the page can no longer be re-rendered on the server. To disable auto-export for this page add `getInitialProps`'
  19 |     )

  at Object.<anonymous> (integration/auto-export-query-error/test/index.test.js:16:22)

test/integration/amphtml-fragment-style/test/index.test.js

AMP Fragment Styles > adds styles from fragment in AMP mode correctly

Expand output

● AMP Fragment Styles › adds styles from fragment in AMP mode correctly

Could not find a valid build in the '/home/runner/work/next.js/next.js/test/integration/amphtml-fragment-style/.next' directory! Try building your app with 'next build' before starting the server.

  889 |         catch (err) {
  890 |             if (!fs_1.default.existsSync(buildIdFile)) {
> 891 |                 throw new Error(`Could not find a valid build in the '${this.distDir}' directory! Try building your app with 'next build' before starting the server.`);
      |                       ^
  892 |             }
  893 |             throw err;
  894 |         }

  at Server.readBuildId (../packages/next/dist/next-server/server/next-server.js:891:23)
  at new Server (../packages/next/dist/next-server/server/next-server.js:53:29)
  at createServer (../packages/next/dist/server/next.js:2:133)
  at Object.<anonymous> (integration/amphtml-fragment-style/test/index.test.js:23:11)

● AMP Fragment Styles › adds styles from fragment in AMP mode correctly

FetchError: request to http://localhost/:undefined/?amp=1 failed, reason: connect ECONNREFUSED 127.0.0.1:80

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

test/integration/build-output/test/index.test.js

Build Output > Basic Application Output > should not include internal pages
Build Output > Custom App Output > should not include custom error
Build Output > Custom Error Output > should not include custom app
Build Output > Custom Static Error Output > should specify /_error as lambda even when static
Build Output > With AMP Output > should not include custom error

Expand output

● Build Output › Basic Application Output › should not include internal pages

expect(received).toMatch(expected)

Expected pattern: /\/ [ ]* \d{1,} B/
Received string:  ""

  23 |       })
  24 | 
> 25 |       expect(stdout).toMatch(/\/ [ ]* \d{1,} B/)
     |                      ^
  26 |       expect(stdout).toMatch(/\+ shared by all [ 0-9.]* kB/)
  27 |       expect(stdout).toMatch(/ runtime\/main\.[0-9a-z]{6}\.js [ 0-9.]* kB/)
  28 |       expect(stdout).toMatch(/ chunks\/framework\.[0-9a-z]{6}\.js [ 0-9. ]* kB/)

  at Object.<anonymous> (integration/build-output/test/index.test.js:25:22)

● Build Output › Custom App Output › should not include custom error

expect(received).toMatch(expected)

Expected pattern: /\/ [ ]* \d{1,} B/
Received string:  ""

  49 |       })
  50 | 
> 51 |       expect(stdout).toMatch(/\/ [ ]* \d{1,} B/)
     |                      ^
  52 |       expect(stdout).toMatch(/\/_app [ ]* \d{1,} B/)
  53 |       expect(stdout).toMatch(/\+ shared by all [ 0-9.]* kB/)
  54 |       expect(stdout).toMatch(/ runtime\/main\.[0-9a-z]{6}\.js [ 0-9.]* kB/)

  at Object.<anonymous> (integration/build-output/test/index.test.js:51:22)

● Build Output › With AMP Output › should not include custom error

expect(received).toMatch(expected)

Expected pattern: /\/ [ 0-9.]* B [ 0-9.]* kB/
Received string:  ""

  76 |       })
  77 | 
> 78 |       expect(stdout).toMatch(/\/ [ 0-9.]* B [ 0-9.]* kB/)
     |                      ^
  79 |       expect(stdout).toMatch(/\/amp .* AMP/)
  80 |       expect(stdout).toMatch(/\/hybrid [ 0-9.]* B/)
  81 |       expect(stdout).toMatch(/\+ shared by all [ 0-9.]* kB/)

  at Object.<anonymous> (integration/build-output/test/index.test.js:78:22)

● Build Output › Custom Error Output › should not include custom app

expect(received).toMatch(expected)

Expected pattern: /\/ [ ]* \d{1,} B/
Received string:  ""

  103 |       })
  104 | 
> 105 |       expect(stdout).toMatch(/\/ [ ]* \d{1,} B/)
      |                      ^
  106 |       expect(stdout).toMatch(/λ \/_error [ ]* \d{1,} B/)
  107 |       expect(stdout).toMatch(/\+ shared by all [ 0-9.]* kB/)
  108 |       expect(stdout).toMatch(/ runtime\/main\.[0-9a-z]{6}\.js [ 0-9.]* kB/)

  at Object.<anonymous> (integration/build-output/test/index.test.js:105:22)

● Build Output › Custom Static Error Output › should specify /_error as lambda even when static

expect(received).toContain(expected) // indexOf

Expected substring: "λ /_error"
Received string:    ""

  140 |         stdout: true,
  141 |       })
> 142 |       expect(stdout).toContain('λ /_error')
      |                      ^
  143 |       expect(stdout).not.toContain('<buildId>')
  144 |     })
  145 |   })

  at Object.<anonymous> (integration/build-output/test/index.test.js:142:22)

test/integration/amp-export-validation/test/index.test.js

AMP Validation on Export > should have shown errors during build
AMP Validation on Export > should export AMP pages
AMP Validation on Export > shows AMP warning without throwing error
AMP Validation on Export > throws error on AMP error
AMP Validation on Export > shows warning and error when throwing error

Expand output

● AMP Validation on Export › should have shown errors during build

expect(received).toMatch(expected)

Expected pattern: /error.*The parent tag of tag 'IMG-I-AMPHTML-INTRINSIC-SIZER' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'\./
Received string:  "(node:2808) UnhandledPromiseRejectionWarning: TypeError: chalk.cyan is not a function

> 1 | "use strict";exports.__esModule=true;exports.wait=wait;exports.error=error;exports.warn=warn;exports.ready=ready;exports.info=info;exports.event=event;var chalk=_interopRequireWildcard(require("chalk"));function _getRequireWildcardCache(){if(typeof WeakMap!=="function")return null;var cache=new WeakMap();_getRequireWildcardCache=function(){return cache;};return cache;}function _interopRequireWildcard(obj){if(obj&&obj.__esModule){return obj;}if(obj===null||typeof obj!=="object"&&typeof obj!=="function"){return{default:obj};}var cache=_getRequireWildcardCache();if(cache&&cache.has(obj)){return cache.get(obj);}var newObj={};var hasPropertyDescriptor=Object.defineProperty&&Object.getOwnPropertyDescriptor;for(var key in obj){if(Object.prototype.hasOwnProperty.call(obj,key)){var desc=hasPropertyDescriptor?Object.getOwnPropertyDescriptor(obj,key):null;if(desc&&(desc.get||desc.set)){Object.defineProperty(newObj,key,desc);}else{newObj[key]=obj[key];}}}newObj.default=obj;if(cache){cache.set(obj,newObj);}return newObj;}const prefixes={wait:chalk.cyan('[ wait ] '),error:chalk.red('[ error ]'),warn:chalk.yellow('[ warn ] '),ready:chalk.green('[ ready ]'),info:chalk.cyan.dim('[ info ] '),event:chalk.magenta('[ event ]')};function wait(...message){console.log(prefixes.wait,...message);}function error(...message){console.log(prefixes.error,...message);}function warn(...message){console.log(prefixes.warn,...message);}function ready(...message){console.log(prefixes.ready,...message);}function info(...message){console.log(prefixes.info,...message);}function event(...message){console.log(prefixes.event,...message);}
    |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            ^

  at Object.<anonymous> (../packages/next/dist/build/output/log.js:1:1052)
  at Object.<anonymous> (../packages/next/dist/build/entries.js:1:426)
  (node:2808) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
  (node:2808) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
  "
  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:29:25)

● AMP Validation on Export › should export AMP pages

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/amp-export-validation/out/first.html'

● AMP Validation on Export › shows AMP warning without throwing error

expect(received).toMatch(expected)

Expected pattern: /error.*The mandatory attribute 'height' is missing in tag 'amp-video'\./
Received string:  ""

  60 |         stderr: true,
  61 |       })
> 62 |       expect(stdout).toMatch(
     |                      ^
  63 |         /error.*The mandatory attribute 'height' is missing in tag 'amp-video'\./
  64 |       )
  65 |       await expect(access(join(outDir, 'cat.html'))).resolves.toBe(undefined)

  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:62:22)

● AMP Validation on Export › throws error on AMP error

expect(received).toMatch(expected)

Expected pattern: /error.*The parent tag of tag 'IMG-I-AMPHTML-INTRINSIC-SIZER' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'/
Received string:  ""

  87 |         stderr: true,
  88 |       })
> 89 |       expect(stdout).toMatch(
     |                      ^
  90 |         /error.*The parent tag of tag 'IMG-I-AMPHTML-INTRINSIC-SIZER' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'/
  91 |       )
  92 |       await expect(access(join(outDir, 'dog.html'))).resolves.toBe(undefined)

  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:89:22)

● AMP Validation on Export › shows warning and error when throwing error

expect(received).toMatch(expected)

Expected pattern: /error.*The parent tag of tag 'IMG-I-AMPHTML-INTRINSIC-SIZER' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'/
Received string:  ""

  114 |         stderr: true,
  115 |       })
> 116 |       expect(stdout).toMatch(
      |                      ^
  117 |         /error.*The parent tag of tag 'IMG-I-AMPHTML-INTRINSIC-SIZER' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'/
  118 |       )
  119 |       expect(stdout).toMatch(

  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:116:22)

test/integration/app-document-import-order/test/index.test.js

Root components import order > root components should be imported in this order _document > _app > page in order to respect side effects
Root components import order > _app chunks should be attached to de dom before page chunks
Root components import order > on dev server > root components should be imported in this order _document > _app > page in order to respect side effects
Root components import order > on dev server > _app chunks should be attached to de dom before page chunks

Expand output

● Root components import order › root components should be imported in this order _document > _app > page in order to respect side effects

Could not find a valid build in the '/home/runner/work/next.js/next.js/test/integration/app-document-import-order/.next' directory! Try building your app with 'next build' before starting the server.

  889 |         catch (err) {
  890 |             if (!fs_1.default.existsSync(buildIdFile)) {
> 891 |                 throw new Error(`Could not find a valid build in the '${this.distDir}' directory! Try building your app with 'next build' before starting the server.`);
      |                       ^
  892 |             }
  893 |             throw err;
  894 |         }

  at Server.readBuildId (../packages/next/dist/next-server/server/next-server.js:891:23)
  at new Server (../packages/next/dist/next-server/server/next-server.js:53:29)
  at createServer (../packages/next/dist/server/next.js:2:133)
  at Object.<anonymous> (integration/app-document-import-order/test/index.test.js:25:11)

● Root components import order › root components should be imported in this order _document > _app > page in order to respect side effects

FetchError: request to http://localhost/:undefined/ failed, reason: connect ECONNREFUSED 127.0.0.1:80

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

● Root components import order › _app chunks should be attached to de dom before page chunks

Could not find a valid build in the '/home/runner/work/next.js/next.js/test/integration/app-document-import-order/.next' directory! Try building your app with 'next build' before starting the server.

  889 |         catch (err) {
  890 |             if (!fs_1.default.existsSync(buildIdFile)) {
> 891 |                 throw new Error(`Could not find a valid build in the '${this.distDir}' directory! Try building your app with 'next build' before starting the server.`);
      |                       ^
  892 |             }
  893 |             throw err;
  894 |         }

  at Server.readBuildId (../packages/next/dist/next-server/server/next-server.js:891:23)
  at new Server (../packages/next/dist/next-server/server/next-server.js:53:29)
  at createServer (../packages/next/dist/server/next.js:2:133)
  at Object.<anonymous> (integration/app-document-import-order/test/index.test.js:25:11)

● Root components import order › _app chunks should be attached to de dom before page chunks

FetchError: request to http://localhost/:undefined/ failed, reason: connect ECONNREFUSED 127.0.0.1:80

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

● Root components import order › on dev server › root components should be imported in this order _document > _app > page in order to respect side effects

Could not find a valid build in the '/home/runner/work/next.js/next.js/test/integration/app-document-import-order/.next' directory! Try building your app with 'next build' before starting the server.

  889 |         catch (err) {
  890 |             if (!fs_1.default.existsSync(buildIdFile)) {
> 891 |                 throw new Error(`Could not find a valid build in the '${this.distDir}' directory! Try building your app with 'next build' before starting the server.`);
      |                       ^
  892 |             }
  893 |             throw err;
  894 |         }

  at Server.readBuildId (../packages/next/dist/next-server/server/next-server.js:891:23)
  at new Server (../packages/next/dist/next-server/server/next-server.js:53:29)
  at createServer (../packages/next/dist/server/next.js:2:133)
  at Object.<anonymous> (integration/app-document-import-order/test/index.test.js:25:11)

● Root components import order › on dev server › root components should be imported in this order _document > _app > page in order to respect side effects

Timeout - Async callback was not invoked within the 60000ms timeout specified by jest.setTimeout.Error: Timeout - Async callback was not invoked within the 60000ms timeout specified by jest.setTimeout.

  at mapper (../node_modules/jest-jasmine2/build/queueRunner.js:25:45)

● Root components import order › on dev server › root components should be imported in this order _document > _app > page in order to respect side effects

FetchError: request to http://localhost:42111/ failed, reason: connect ECONNREFUSED 127.0.0.1:42111

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

● Root components import order › on dev server › _app chunks should be attached to de dom before page chunks

Could not find a valid build in the '/home/runner/work/next.js/next.js/test/integration/app-document-import-order/.next' directory! Try building your app with 'next build' before starting the server.

  889 |         catch (err) {
  890 |             if (!fs_1.default.existsSync(buildIdFile)) {
> 891 |                 throw new Error(`Could not find a valid build in the '${this.distDir}' directory! Try building your app with 'next build' before starting the server.`);
      |                       ^
  892 |             }
  893 |             throw err;
  894 |         }

  at Server.readBuildId (../packages/next/dist/next-server/server/next-server.js:891:23)
  at new Server (../packages/next/dist/next-server/server/next-server.js:53:29)
  at createServer (../packages/next/dist/server/next.js:2:133)
  at Object.<anonymous> (integration/app-document-import-order/test/index.test.js:25:11)

● Root components import order › on dev server › _app chunks should be attached to de dom before page chunks

Timeout - Async callback was not invoked within the 60000ms timeout specified by jest.setTimeout.Error: Timeout - Async callback was not invoked within the 60000ms timeout specified by jest.setTimeout.

  at mapper (../node_modules/jest-jasmine2/build/queueRunner.js:25:45)

● Root components import order › on dev server › _app chunks should be attached to de dom before page chunks

FetchError: request to http://localhost:42111/ failed, reason: connect ECONNREFUSED 127.0.0.1:42111

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

timneutkens · 2020-03-22T14:25:26Z

packages/next/build/output/log.ts

-  ready: chalk`[ {green ready} ]`,
-  info: chalk`[ {cyan {dim info}} ] `,
-  event: chalk`[ {magenta event} ]`,
+  wait: chalk.cyan('[ wait ] '),


This changes the coloring of the output.

It should be [ ${chalk.cyan('wait')} ]

Same for the other messages

ijjk · 2020-03-22T14:46:04Z

Failing test suites

test/integration/amp-export-validation/test/index.test.js

AMP Validation on Export > should have shown errors during build
AMP Validation on Export > should export AMP pages
AMP Validation on Export > shows AMP warning without throwing error
AMP Validation on Export > throws error on AMP error
AMP Validation on Export > shows warning and error when throwing error

Expand output

● AMP Validation on Export › should have shown errors during build

expect(received).toMatch(expected)

Expected pattern: /error.*The parent tag of tag 'IMG-I-AMPHTML-INTRINSIC-SIZER' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'\./
Received string:  "(node:2888) UnhandledPromiseRejectionWarning: TypeError: chalk.cyan is not a function

> 1 | "use strict";exports.__esModule=true;exports.wait=wait;exports.error=error;exports.warn=warn;exports.ready=ready;exports.info=info;exports.event=event;var chalk=_interopRequireWildcard(require("chalk"));function _getRequireWildcardCache(){if(typeof WeakMap!=="function")return null;var cache=new WeakMap();_getRequireWildcardCache=function(){return cache;};return cache;}function _interopRequireWildcard(obj){if(obj&&obj.__esModule){return obj;}if(obj===null||typeof obj!=="object"&&typeof obj!=="function"){return{default:obj};}var cache=_getRequireWildcardCache();if(cache&&cache.has(obj)){return cache.get(obj);}var newObj={};var hasPropertyDescriptor=Object.defineProperty&&Object.getOwnPropertyDescriptor;for(var key in obj){if(Object.prototype.hasOwnProperty.call(obj,key)){var desc=hasPropertyDescriptor?Object.getOwnPropertyDescriptor(obj,key):null;if(desc&&(desc.get||desc.set)){Object.defineProperty(newObj,key,desc);}else{newObj[key]=obj[key];}}}newObj.default=obj;if(cache){cache.set(obj,newObj);}return newObj;}const prefixes={wait:`[ ${chalk.cyan('wait')} ] `,error:`[ ${chalk.red('error')} ]`,warn:`[ ${chalk.yellow('warn')} ] `,ready:`[ ${chalk.green('ready')} ]`,info:`[ ${chalk.cyan.dim('info')} ] `,event:`[ ${chalk.magenta('event')} ]`};function wait(...message){console.log(prefixes.wait,...message);}function error(...message){console.log(prefixes.error,...message);}function warn(...message){console.log(prefixes.warn,...message);}function ready(...message){console.log(prefixes.ready,...message);}function info(...message){console.log(prefixes.info,...message);}function event(...message){console.log(prefixes.event,...message);}
    |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 ^

  at Object.<anonymous> (../packages/next/dist/build/output/log.js:1:1057)
  at Object.<anonymous> (../packages/next/dist/build/entries.js:1:426)
  (node:2888) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
  (node:2888) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
  "
  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:29:25)

● AMP Validation on Export › should export AMP pages

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/amp-export-validation/out/first.html'

● AMP Validation on Export › shows AMP warning without throwing error

expect(received).toMatch(expected)

Expected pattern: /error.*The mandatory attribute 'height' is missing in tag 'amp-video'\./
Received string:  ""

  60 |         stderr: true,
  61 |       })
> 62 |       expect(stdout).toMatch(
     |                      ^
  63 |         /error.*The mandatory attribute 'height' is missing in tag 'amp-video'\./
  64 |       )
  65 |       await expect(access(join(outDir, 'cat.html'))).resolves.toBe(undefined)

  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:62:22)

● AMP Validation on Export › throws error on AMP error

expect(received).toMatch(expected)

Expected pattern: /error.*The parent tag of tag 'IMG-I-AMPHTML-INTRINSIC-SIZER' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'/
Received string:  ""

  87 |         stderr: true,
  88 |       })
> 89 |       expect(stdout).toMatch(
     |                      ^
  90 |         /error.*The parent tag of tag 'IMG-I-AMPHTML-INTRINSIC-SIZER' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'/
  91 |       )
  92 |       await expect(access(join(outDir, 'dog.html'))).resolves.toBe(undefined)

  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:89:22)

● AMP Validation on Export › shows warning and error when throwing error

expect(received).toMatch(expected)

Expected pattern: /error.*The parent tag of tag 'IMG-I-AMPHTML-INTRINSIC-SIZER' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'/
Received string:  ""

  114 |         stderr: true,
  115 |       })
> 116 |       expect(stdout).toMatch(
      |                      ^
  117 |         /error.*The parent tag of tag 'IMG-I-AMPHTML-INTRINSIC-SIZER' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'/
  118 |       )
  119 |       expect(stdout).toMatch(

  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:116:22)

test/integration/auto-export-query-error/test/index.test.js

Auto Export > server mode > should show warning for query provided for auto exported page correctly
Auto Export > serverless mode > should show warning for query provided for auto exported page correctly

Expand output

● Auto Export › server mode › should show warning for query provided for auto exported page correctly

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 0

  14 | const runTests = () => {
  15 |   it('should show warning for query provided for auto exported page correctly', async () => {
> 16 |     expect(exitCode).toBe(1)
     |                      ^
  17 |     expect(stderr).toContain(
  18 |       'Error: you provided query values for / which is an auto-exported page. These can not be applied since the page can no longer be re-rendered on the server. To disable auto-export for this page add `getInitialProps`'
  19 |     )

  at Object.<anonymous> (integration/auto-export-query-error/test/index.test.js:16:22)

● Auto Export › serverless mode › should show warning for query provided for auto exported page correctly

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 0

  14 | const runTests = () => {
  15 |   it('should show warning for query provided for auto exported page correctly', async () => {
> 16 |     expect(exitCode).toBe(1)
     |                      ^
  17 |     expect(stderr).toContain(
  18 |       'Error: you provided query values for / which is an auto-exported page. These can not be applied since the page can no longer be re-rendered on the server. To disable auto-export for this page add `getInitialProps`'
  19 |     )

  at Object.<anonymous> (integration/auto-export-query-error/test/index.test.js:16:22)

test/integration/amphtml-fragment-style/test/index.test.js

AMP Fragment Styles > adds styles from fragment in AMP mode correctly

Expand output

● AMP Fragment Styles › adds styles from fragment in AMP mode correctly

Could not find a valid build in the '/home/runner/work/next.js/next.js/test/integration/amphtml-fragment-style/.next' directory! Try building your app with 'next build' before starting the server.

  889 |         catch (err) {
  890 |             if (!fs_1.default.existsSync(buildIdFile)) {
> 891 |                 throw new Error(`Could not find a valid build in the '${this.distDir}' directory! Try building your app with 'next build' before starting the server.`);
      |                       ^
  892 |             }
  893 |             throw err;
  894 |         }

  at Server.readBuildId (../packages/next/dist/next-server/server/next-server.js:891:23)
  at new Server (../packages/next/dist/next-server/server/next-server.js:53:29)
  at createServer (../packages/next/dist/server/next.js:2:133)
  at Object.<anonymous> (integration/amphtml-fragment-style/test/index.test.js:23:11)

● AMP Fragment Styles › adds styles from fragment in AMP mode correctly

FetchError: request to http://localhost/:undefined/?amp=1 failed, reason: connect ECONNREFUSED 127.0.0.1:80

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

test/integration/auto-export-serverless/test/index.test.js

Auto Export Serverless > Refreshes query on mount

Expand output

● Auto Export Serverless › Refreshes query on mount

expect(received).toMatch(expected)

Expected pattern: /post.*post-1/
Received string:  ""

  18 |     const browser = await webdriver(appPort, '/post-1')
  19 |     const html = await browser.eval('document.body.innerHTML')
> 20 |     expect(html).toMatch(/post.*post-1/)
     |                  ^
  21 |     expect(html).toMatch(/nextExport/)
  22 | 
  23 |     await killApp(app)

  at Object.<anonymous> (integration/auto-export-serverless/test/index.test.js:20:18)

test/integration/amphtml-custom-validator/test/index.test.js

AMP Custom Validator > should build and start successfully
AMP Custom Validator > should run in dev mode successfully

Expand output

● AMP Custom Validator › should build and start successfully

FetchError: request to http://localhost:37849/ failed, reason: connect ECONNREFUSED 127.0.0.1:37849

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

● AMP Custom Validator › should run in dev mode successfully

: Timeout - Async callback was not invoked within the 60000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 60000ms timeout specified by jest.setTimeout.Error:

  31 |   })
  32 | 
> 33 |   it('should run in dev mode successfully', async () => {
     |   ^
  34 |     let stderr = ''
  35 | 
  36 |     appPort = await findPort()

  at new Spec (../node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
  at Suite.<anonymous> (integration/amphtml-custom-validator/test/index.test.js:33:3)

test/integration/404-page-custom-error/test/index.test.js

Default 404 Page with custom _error > dev mode > should respond to 404 correctly
Default 404 Page with custom _error > dev mode > should render error correctly
Default 404 Page with custom _error > dev mode > should render index page normal
Default 404 Page with custom _error > server mode > should build successfully
Default 404 Page with custom _error > server mode > should respond to 404 correctly
Default 404 Page with custom _error > server mode > should render error correctly
Default 404 Page with custom _error > server mode > should render index page normal
Default 404 Page with custom _error > server mode > should set pages404 in routes-manifest correctly
Default 404 Page with custom _error > server mode > should have output 404.html
Default 404 Page with custom _error > serverless mode > should build successfully
Default 404 Page with custom _error > serverless mode > should respond to 404 correctly
Default 404 Page with custom _error > serverless mode > should render error correctly
Default 404 Page with custom _error > serverless mode > should render index page normal
Default 404 Page with custom _error > serverless mode > should set pages404 in routes-manifest correctly

Expand output

● Default 404 Page with custom _error › server mode › should build successfully

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-custom-error/.next/BUILD_ID'

● Default 404 Page with custom _error › server mode › should respond to 404 correctly

FetchError: request to http://localhost:36977/404 failed, reason: connect ECONNREFUSED 127.0.0.1:36977

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

● Default 404 Page with custom _error › server mode › should render error correctly

FetchError: request to http://localhost:36977/err failed, reason: connect ECONNREFUSED 127.0.0.1:36977

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

● Default 404 Page with custom _error › server mode › should render index page normal

FetchError: request to http://localhost:36977/ failed, reason: connect ECONNREFUSED 127.0.0.1:36977

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

● Default 404 Page with custom _error › server mode › should set pages404 in routes-manifest correctly

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-custom-error/.next/routes-manifest.json'

● Default 404 Page with custom _error › server mode › should have output 404.html

TypeError: The "path" argument must be of type string. Received undefinedTypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined

  55 |               '.next',
  56 |               ...(mode === 'server'
> 57 |                 ? ['server', 'static', buildId, 'pages']
     |                                        ^
  58 |                 : ['serverless', 'pages']),
  59 |               '404.html'
  60 |             )

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:57:40)

● Default 404 Page with custom _error › serverless mode › should build successfully

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-custom-error/.next/BUILD_ID'

● Default 404 Page with custom _error › serverless mode › should respond to 404 correctly

FetchError: request to http://localhost:44499/404 failed, reason: connect ECONNREFUSED 127.0.0.1:44499

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

● Default 404 Page with custom _error › serverless mode › should render error correctly

FetchError: request to http://localhost:44499/err failed, reason: connect ECONNREFUSED 127.0.0.1:44499

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

● Default 404 Page with custom _error › serverless mode › should render index page normal

FetchError: request to http://localhost:44499/ failed, reason: connect ECONNREFUSED 127.0.0.1:44499

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

● Default 404 Page with custom _error › serverless mode › should set pages404 in routes-manifest correctly

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-custom-error/.next/routes-manifest.json'

● Default 404 Page with custom _error › dev mode › should respond to 404 correctly

Timeout - Async callback was not invoked within the 120000ms timeout specified by jest.setTimeout.Error: Timeout - Async callback was not invoked within the 120000ms timeout specified by jest.setTimeout.

  at mapper (../node_modules/jest-jasmine2/build/queueRunner.js:25:45)

● Default 404 Page with custom _error › dev mode › should respond to 404 correctly

FetchError: request to http://localhost:37531/404 failed, reason: connect ECONNREFUSED 127.0.0.1:37531

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

● Default 404 Page with custom _error › dev mode › should render error correctly

Timeout - Async callback was not invoked within the 120000ms timeout specified by jest.setTimeout.Error: Timeout - Async callback was not invoked within the 120000ms timeout specified by jest.setTimeout.

  at mapper (../node_modules/jest-jasmine2/build/queueRunner.js:25:45)

● Default 404 Page with custom _error › dev mode › should render error correctly

FetchError: request to http://localhost:37531/err failed, reason: connect ECONNREFUSED 127.0.0.1:37531

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

● Default 404 Page with custom _error › dev mode › should render index page normal

Timeout - Async callback was not invoked within the 120000ms timeout specified by jest.setTimeout.Error: Timeout - Async callback was not invoked within the 120000ms timeout specified by jest.setTimeout.

  at mapper (../node_modules/jest-jasmine2/build/queueRunner.js:25:45)

● Default 404 Page with custom _error › dev mode › should render index page normal

FetchError: request to http://localhost:37531/ failed, reason: connect ECONNREFUSED 127.0.0.1:37531

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1455:11)

ijjk · 2020-04-04T20:01:54Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
buildDuration	9.7s	9.8s	⚠️ +124ms
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +613 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5272.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.3 kB	56.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.75 kB	6.75 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
index.html gzip	917 B	917 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	914 B	914 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
buildDuration	10.4s	11.6s	⚠️ +1.1s
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +613 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5272.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.3 kB	56.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.75 kB	6.75 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_error.js gzip	233 kB	233 kB	✓
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	956 B	956 B	✓
index.js gzip	233 kB	233 kB	-181 B
link.js gzip	243 kB	243 kB	-72 B
routerDirect.js gzip	241 kB	241 kB	⚠️ +93 B
withRouter.js gzip	241 kB	241 kB	-9 B
Overall change	1.19 MB	1.19 MB	-169 B

ijjk · 2020-04-04T20:18:41Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
buildDuration	10.2s	10.1s	-110ms
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +573 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5272.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.3 kB	56.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.75 kB	6.75 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
index.html gzip	917 B	917 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	914 B	914 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
buildDuration	10.8s	10.7s	-56ms
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +573 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5272.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.3 kB	56.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.75 kB	6.75 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_error.js gzip	233 kB	233 kB	-20 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	956 B	956 B	✓
index.js gzip	233 kB	233 kB	⚠️ +11 B
link.js gzip	243 kB	243 kB	⚠️ +15 B
routerDirect.js gzip	241 kB	241 kB	-49 B
withRouter.js gzip	241 kB	241 kB	⚠️ +43 B
Overall change	1.19 MB	1.19 MB	✓

ijjk · 2020-04-05T04:57:19Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
buildDuration	10.6s	10.7s	⚠️ +56ms
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +573 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5272.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.3 kB	56.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.75 kB	6.75 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
index.html gzip	917 B	917 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	914 B	914 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
buildDuration	11.5s	11.3s	-226ms
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +573 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5272.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.3 kB	56.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.75 kB	6.75 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	matamatanot/next.js update-chalk	Change
_error.js gzip	233 kB	233 kB	-5 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	956 B	956 B	✓
index.js gzip	233 kB	233 kB	-180 B
link.js gzip	243 kB	243 kB	⚠️ +250 B
routerDirect.js gzip	241 kB	241 kB	-127 B
withRouter.js gzip	241 kB	241 kB	⚠️ +3 B
Overall change	1.19 MB	1.19 MB	-59 B

…ate-chalk

Timer

Can you please add a test to make sure Internet Explorer 11 works in development mode? I'm pretty sure this introduces syntax that breaks IE11 support.

matamatanot · 2020-04-06T15:42:21Z

@Timer
About Object.setPrototypeOf ?
Chalk is not a browser package. Run on Node.js >10 ,not on browser.
I don't know why I have to worry about IE11.

And I've never written a test for IE11 before. I can't seems to be of any help.

timneutkens · 2020-04-06T15:47:16Z

In development Next.js has to run strip-ansi against certain output hence why it's needed browser-side.

timneutkens · 2020-04-06T16:03:36Z

Let's keep this dependency as-is for now, there is no explicit need to upgrade right now.

matamatanot · 2020-04-06T17:21:00Z

chalk/chalk#300

Browser DevTools support built-in? This has been a common request and as long as it doesn't require too much code (and no new dependencies), I welcome a PR adding it.

update chalk 3.0.0

b0ee574

matamatanot requested review from ijjk, lfades, Timer and timneutkens as code owners March 22, 2020 02:31

fix prefixes

cb5bf9f

timneutkens reviewed Mar 22, 2020

View reviewed changes

Use template literals

9c6e26e

matamatanot and others added 4 commits March 31, 2020 10:30

Merge branch 'canary' into update-chalk

c2769d2

update misc

ffde731

Merge remote-tracking branch 'upstream/canary' into update-chalk

e73ea2d

not use as

aa702a3

update 4.0.0

14f547f

matamatanot changed the title ~~Upgrade chalk 3.0.0~~ Upgrade chalk 4.0.0 Apr 4, 2020

update yarn.lock

85b02f4

timneutkens added the type: next label Apr 6, 2020

Merge branch 'canary' of github.com:zeit/next.js into matamatanot-upd…

e636aa7

…ate-chalk

timneutkens approved these changes Apr 6, 2020

View reviewed changes

Timer requested changes Apr 6, 2020

View reviewed changes

timneutkens closed this Apr 6, 2020

matamatanot mentioned this pull request Oct 2, 2020

Upgrade all packages to Chalk 4. #17559

Closed

matamatanot deleted the update-chalk branch October 30, 2021 09:54

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade chalk 4.0.0 #11268

Upgrade chalk 4.0.0 #11268

matamatanot commented Mar 22, 2020

ijjk commented Mar 22, 2020 •

edited

timneutkens Mar 22, 2020

ijjk commented Mar 22, 2020 •

edited

ijjk commented Apr 4, 2020

ijjk commented Apr 4, 2020

ijjk commented Apr 5, 2020

Timer left a comment

matamatanot commented Apr 6, 2020

timneutkens commented Apr 6, 2020

timneutkens commented Apr 6, 2020

matamatanot commented Apr 6, 2020

Upgrade chalk 4.0.0 #11268

Upgrade chalk 4.0.0 #11268

Conversation

matamatanot commented Mar 22, 2020

ijjk commented Mar 22, 2020 • edited

Failing test suites

timneutkens Mar 22, 2020

Choose a reason for hiding this comment

ijjk commented Mar 22, 2020 • edited

Failing test suites

ijjk commented Apr 4, 2020

Stats from current PR

ijjk commented Apr 4, 2020

Stats from current PR

ijjk commented Apr 5, 2020

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

matamatanot commented Apr 6, 2020

timneutkens commented Apr 6, 2020

timneutkens commented Apr 6, 2020

matamatanot commented Apr 6, 2020

ijjk commented Mar 22, 2020 •

edited

ijjk commented Mar 22, 2020 •

edited