Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all packages to Chalk 4. #17559

Closed
wants to merge 1 commit into from
Closed

Upgrade all packages to Chalk 4. #17559

wants to merge 1 commit into from

Conversation

ludofischer
Copy link
Contributor

  • Let all packages use the same Chalk major version.
  • Replace removed .constructor() with equivalent .Instance().
  • Don’t use set the removed enabled property when creating a Chalk instance. I believe it had no effect anyway,
    as it was always set to true which was the default.

Chalk 4 requires Node >= 10, but that should work as Next requires Node >= 10 too.
Chalk changelog: https://github.com/chalk/chalk/releases

- Let all packages use the same Chalk major version.
- Replace removed `.constructor()` with equivalent `.Instance()`.
- Don’t use set the removed `enabled` property when creating a Chalk instance.  I believe it had no effect anyway,
  as it was set to `true` which was the default.

Chalk 4 requires Node >= 10, but that should work as Next requires Node >= 10 too.
Chalk changelog: https://github.com/chalk/chalk/releases
@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. type: next labels Oct 2, 2020
@ijjk
Copy link
Member

ijjk commented Oct 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
buildDuration 13s 13s -35ms
nodeModulesSize 63.1 MB 63.1 MB ⚠️ +259 B
Page Load Tests Overall increase ✓
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
/ failed reqs 0 0
/ total time (seconds) 2.344 2.373 ⚠️ +0.03
/ avg req/sec 1066.71 1053.46 ⚠️ -13.25
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.302 1.268 -0.03
/error-in-render avg req/sec 1920.31 1971.27 +50.96
Client Bundles (main, webpack, commons)
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB
framework.HASH.js gzip 39 kB 39 kB
main-d493e7d..42f5.js gzip 7.17 kB 7.17 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.8 kB 57.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-f8905d4..dule.js gzip 6.24 kB 6.24 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 996 B 996 B
Overall change 3.01 kB 3.01 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
buildDuration 14.4s 14.6s ⚠️ +267ms
nodeModulesSize 63.1 MB 63.1 MB ⚠️ +259 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB
framework.HASH.js gzip 39 kB 39 kB
main-d493e7d..42f5.js gzip 7.17 kB 7.17 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.8 kB 57.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-f8905d4..dule.js gzip 6.24 kB 6.24 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary ludovicofischer/next.js chalk-4 Change
_error.js 1.05 MB 1.05 MB ⚠️ +58 B
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.05 MB 1.05 MB ⚠️ +58 B
link.js 1.1 MB 1.1 MB ⚠️ +58 B
routerDirect.js 1.09 MB 1.09 MB ⚠️ +58 B
withRouter.js 1.09 MB 1.09 MB ⚠️ +58 B
Overall change 5.4 MB 5.4 MB ⚠️ +290 B
Commit: 56ca20d

@matamatanot
Copy link
Contributor

@ludovicofischer

Check #11268 out.
Chalk@3^ is not compatible with IE11.

@ludofischer
Copy link
Contributor Author

@matamatanot Whoops! Sorry did not think to check closed pull requests. I wonder why my commit seems to work without changing imports, either it’s not for now it seems.

@ludofischer ludofischer closed this Oct 2, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants