fix: Disable compile time evaluation of import.meta.url

[bjoluc]

I'm affected by webpack/webpack#14445, fixed in webpack/webpack#15246, available in webpack >= v5.68.0, so I'd love to have an ncc version using webpack >= v5.68.0!

EDIT: Forgot to actually set the corresponding config option at first, added that in f19ab9c.

[styfle]

Thanks for the PR!

Can you add a test to ensure this behavior is working as intended?

[bjoluc]

I added a unit test to validate that import.meta.url is not replaced in ESM builds. If CJS builds require modules that use import.meta.url, it is not evaluated as well – which may lead to runtime errors in the CJS bundle, the counter part of #895 and a separate problem of mixed CJS-ESM/ESM-CJS builds. I'd consider not evaluating import.meta.url in CJS bundles consistent though with not evaluating __dirname in ESM builds. How to fix the whole problem is a bit out of my expertise unfortunately 😕

I think some test fixtures also need to be updated due to the new webpack version? I'm happy to leave that to you though, if that's ok 😁

[styfle]

Looks like the issue is here

ncc/test/watcher.test.js

Lines 79 to 92 in a9c07e0

	return {
	close: () => {
	this.watchEnd();
	},
	pause: () => {
	this.paused = true;
	},
	getFileTimestamps: () => {
	return this.timestamps;
	},
	getContextTimestamps: () => {
	return this.timestamps;
	}
	};

The returned object no longer matches the latest webpack expected type here https://github.com/webpack/webpack/blob/d3a0f8de03f26a83b4d5db3cfe177617a3801df3/types.d.ts#L12062-L12097

[aruniverse]

@bjoluc @styfle anyway to help push this pr along?

[bjoluc]

@styfle Thanks for pointing me to the watcher implementation!

I updated the CustomWatchFileSystem class according to the new one over at webpack and watcher.test.js passes again. I didn't implement the bunch of deprecated getters from the Watcher interface in favor of the generic getInfo() which seems to be enough. Not an expert here though. Maybe @guybedford can quickly skim over a4ce744 and check if anything looks wildly wrong?

[styfle]

Great work, thanks! 🎉