Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncc hardcodes import.meta.url #30

Closed
bjoluc opened this issue Mar 25, 2022 · 2 comments
Closed

ncc hardcodes import.meta.url #30

bjoluc opened this issue Mar 25, 2022 · 2 comments
Labels
bug Something isn't working released

Comments

@bjoluc
Copy link
Owner

bjoluc commented Mar 25, 2022

Version 4.2.0 is broken due to hardcoded asset paths like /home/runner/work/jspsych-builder/jspsych-builder/assets/template/package.tmpl.json. Fixing this tomorrow.
@bjoluc bjoluc changed the title ncc hardcodes absolute asset paths ncc hardcodes import.meta.url Mar 26, 2022
@bjoluc
Copy link
Owner Author

bjoluc commented Mar 26, 2022

Proposed a workaround in vercel/ncc#897 and published it to @bjoluc/ncc-import-meta-fix so we can use it for now.

@bjoluc bjoluc closed this as completed in 86ca71b Mar 26, 2022
github-actions bot pushed a commit that referenced this issue Mar 26, 2022
@semantic-release-bot
chore(release): 4.2.1 [skip ci]
a2bde27 
### [4.2.1](v4.2.0...v4.2.1) (2022-03-26)

### Bug Fixes

* Fix file/module not found errors due to paths that were hardcoded at compile time ([86ca71b](86ca71b)), closes [#30](#30)
@github-actions
Copy link

🎉 This issue has been resolved in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bjoluc bjoluc added the bug Something isn't working label Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjoluc