Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add timeFormatType field #8320

Merged
merged 16 commits into from Aug 4, 2022
Merged

feat: Add timeFormatType field #8320

merged 16 commits into from Aug 4, 2022

Conversation

lsh
Copy link
Member

@lsh lsh commented Jul 25, 2022

Allows for the use of timeFormatType similar to numberFormatType.

📦 Published PR as canary version: 5.4.1--canary.8320.193f79b.0

✨ Test out this PR locally via:

npm install vega-lite@5.4.1--canary.8320.193f79b.0
# or 
yarn add vega-lite@5.4.1--canary.8320.193f79b.0

Version

Published prerelease version: v5.4.1-next.0

Changelog

🐛 Bug Fix

Authors: 4

src/config.ts Outdated Show resolved Hide resolved
@lsh lsh marked this pull request as ready for review July 27, 2022 20:12
@lsh lsh requested a review from kanitw July 27, 2022 20:43
Copy link
Member

@kanitw kanitw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but the main one is don't we have to check for time unit in formatSignalRef?

src/compile/format.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/compile/format.ts Show resolved Hide resolved
@kanitw kanitw merged commit 5995ece into next Aug 4, 2022
@kanitw kanitw deleted the lsh/timeFormatType branch August 4, 2022 06:01
@vega-org-bot
Copy link
Collaborator

🚀 PR was released in v5.5.0 🚀

@vega-org-bot vega-org-bot added released This PR has been released by auto shipit and removed prerelease labels Aug 15, 2022
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This PR has been released by auto shipit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants