Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use GITHUB_TOKEN instead of PAT #1017

Merged
merged 3 commits into from Nov 21, 2021
Merged

ci: use GITHUB_TOKEN instead of PAT #1017

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09dac90
ci: use GITHUB_TOKEN instead of PAT
domoritz Nov 17, 2021
f5848fa
Try yarn release
domoritz Nov 19, 2021
a612074
remove cache
domoritz Nov 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/publish-auto.yml
View file
Open in desktop
Expand Up @@ -26,7 +26,8 @@ jobs:
run: yarn --frozen-lockfile

- name: Create release
run: npm run release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if using yarn run release might have better results than npm run release, noticed we are seeing the cleanup error in CI again https://github.com/vega/ts-json-schema-generator/runs/4232722268?check_suite_focus=true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try in f5848fa

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fails: https://github.com/vega/ts-json-schema-generator/runs/4269550305?check_suite_focus=true

env:
GITHUB_TOKEN: ${{ secrets.GH_PAT }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
run: yarn run release
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}