ci: use GITHUB_TOKEN instead of PAT #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydrosquall
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
As discussed in slack:
a PAT is needed if the branch that auto commits to is protected . If we leave the branch unprotected, it won't be needed.
https://github.community/t/how-to-push-to-protected-branches-in-a-github-action/16101/10
Since stable is unprotected (check: https://a.cl.ly/nOu5Q7L9 ), this should work.
hydrosquall
reviewed
Nov 19, 2021
| @@ -26,7 +26,8 @@ jobs: | |||
| run: yarn --frozen-lockfile | |||
|
|
|||
| - name: Create release | |||
| run: npm run release | |||
There was a problem hiding this comment.
Wondering if using yarn run release might have better results than npm run release, noticed we are seeing the cleanup error in CI again https://github.com/vega/ts-json-schema-generator/runs/4232722268?check_suite_focus=true
There was a problem hiding this comment.
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Published PR as canary version:
0.97.1--canary.1017.a612074.0✨ Test out this PR locally via:
npm install ts-json-schema-generator@0.97.1--canary.1017.a612074.0 # or yarn add ts-json-schema-generator@0.97.1--canary.1017.a612074.0