chore(deps): update #5999
chore(deps): update #5999
Conversation
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
There was a problem hiding this comment.
In general this looks good!
I'd like to see us do a little investigation to decide if the large enum variants are OK or if it might be better to box the large ones. Assuming we are ok with it, it'd be nice to leave comments next to the #[allow] blocks about why we are ok with them.
lib/remap-lang/src/value.rs
Outdated
| @@ -15,6 +15,7 @@ use std::str::FromStr; | |||
|
|
|||
| pub use kind::Kind; | |||
|
|
|||
| #[allow(clippy::large_enum_variant)] | |||
There was a problem hiding this comment.
It'd be nice to add comments for these allows about why we allow them.
There was a problem hiding this comment.
I checked regex code for understanding why we actually get this error. So regex use thread_local for some cache. Version 1.1.0 of thread_local was released on Jan 8, 2021 and one of the changes was inline data to structure from the Box:
https://github.com/Amanieu/thread_local-rs/blob/v1.0.1/src/lib.rs#L95
vs
https://github.com/Amanieu/thread_local-rs/blob/v1.1.0/src/lib.rs#L107
Changes were made in this PR: Amanieu/thread_local-rs#22
I'm not sure how this change will affect vector memory consumption, so will revert thread_local update and create a separate issue for this.
|
Noting that I'm fine opening a follow-up issue for investigating the large enum variants since this PR doesn't change that. |
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
|
@fanatid 👍 thanks for investigating! |
futureschore(deps): bump futures from 0.3.8 to 0.3.9 #5952pin-projectchore(deps): bump pin-project from 1.0.2 to 1.0.4 #5969randchore(deps): bump rand from 0.8.0 to 0.8.1 #5953cargo update --aggressive