Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update thread_local dependency? #6005

Closed
fanatid opened this issue Jan 12, 2021 · 1 comment
Closed

Update thread_local dependency? #6005

fanatid opened this issue Jan 12, 2021 · 1 comment
Labels
domain: deps Anything related to Vector's dependencies

Comments

@fanatid
Copy link
Contributor

fanatid commented Jan 12, 2021

With new version of thread_local (1.1.0) structs which use CachedThreadLocal increase their own size from 48 bytes to 544. I'm not sure how this will change vector memory consumption so I not updated thread_local in #5999 (comment). We need to figure this out before update it (I guess everything will look ok but better check).
@fanatid fanatid added the domain: deps Anything related to Vector's dependencies label Jan 12, 2021
jszwedko added a commit that referenced this issue Jan 18, 2021
@jszwedko
chore(tests): Pin thread_local to 1.0.1
2f02026 
Until #6005 is resolved.

Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
@jszwedko jszwedko mentioned this issue Jan 18, 2021
Merged
jszwedko added a commit that referenced this issue Jan 18, 2021
@jszwedko
chore(tests): Pin thread_local to 1.0.1 (#6114)
52a6cc4 
Until #6005 is resolved.

Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
@jszwedko
Copy link
Member

CachedThreadLocal was deprecated and replaced with a simple wrapper over ThreadLocal. This decreases Regex's size back down to 16 bytes.

jszwedko added a commit that referenced this issue Mar 29, 2021
@jszwedko
chore(deps): Remove thread_local pinning
8c5bc7e 
Follow up to #6005 where it was
upgraded as the size of the struct was reduced.

Removed unnecessary allow(clippy::large_enum_variant)

Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
@jszwedko jszwedko mentioned this issue Mar 29, 2021
Merged
jszwedko added a commit that referenced this issue Mar 30, 2021
@jszwedko
chore(deps): Remove thread_local pinning (#6917)
07a5427 
Follow up to #6005 where it was
upgraded as the size of the struct was reduced.

Removed unnecessary allow(clippy::large_enum_variant)

Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: deps Anything related to Vector's dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jszwedko @fanatid