feat: make popover modeless by default, add modality properties #7412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
reviewed
May 15, 2024
web-padawan
changed the title
web-padawan
force-pushed
the
feat/popover-dialog-features
branch
2 times, most recently
from
a75f194
to
2cb5d3c
Compare
|
Note: extracted closing logic to #7414, will update this PR to be based on that one. |
web-padawan
force-pushed
the
feat/popover-dialog-features
branch
3 times, most recently
from
599ff25
to
9fc2cc3
Compare
web-padawan
force-pushed
the
feat/popover-dialog-features
branch
from
9fc2cc3
to
3ca5bed
Compare
tomivirkki
approved these changes
May 16, 2024
vursen
reviewed
May 16, 2024
vursen
reviewed
May 16, 2024
vursen
approved these changes
May 16, 2024
|
vursen
approved these changes
May 16, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modelessproperty on the overlay by default, addedmodalproperty (default to false),withBackdropproperty tovaadin-popoverthat works the same as invaadin-dialogwhen modal,pointer-events: nonewhen the popover is non-modal (to allow target clicks),clicklistener to also close on outside click when the overlay is modeless.Type of change