-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to Spring Boot 3 RC2 #15098
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,18 +85,18 @@ | |
<failOnMissingWebXml>false</failOnMissingWebXml> | ||
|
||
<!-- Dependencies --> | ||
<spring.version>6.0.0-RC2</spring.version> | ||
<spring.boot.version>3.0.0-RC1</spring.boot.version> | ||
<spring.security.version>6.0.0-RC1</spring.security.version> | ||
<spring.version>6.0.0-RC4</spring.version> | ||
<spring.boot.version>3.0.0-RC2</spring.boot.version> | ||
<spring.security.version>6.0.0-RC2</spring.security.version> | ||
<spring.security.oauth2.authorization.server.version>1.0.0-RC1</spring.security.oauth2.authorization.server.version> | ||
<gwt.version>2.9.0</gwt.version> | ||
<hibernate.validator.version>7.0.5.Final</hibernate.validator.version> | ||
<hibernate.validator.version>8.0.0.Final</hibernate.validator.version> | ||
<slf4j.version>2.0.3</slf4j.version> | ||
<polymer.version>2.6.1</polymer.version> | ||
<jackson.version>2.14.0-rc2</jackson.version> | ||
<jackson.databind.version>2.14.0-rc2</jackson.databind.version> | ||
<jackson.version>2.14.0</jackson.version> | ||
<jackson.databind.version>2.14.0</jackson.databind.version> | ||
<jakarta.validation.version>3.0.2</jakarta.validation.version> | ||
<jakarta.annotation.api.version>2.0.0</jakarta.annotation.api.version> | ||
<jakarta.annotation.api.version>2.1.1</jakarta.annotation.api.version> | ||
<jaxb.version>4.0.1</jaxb.version> | ||
|
||
<!-- Plugins --> | ||
|
@@ -235,7 +235,7 @@ | |
<dependency> | ||
<groupId>jakarta.servlet</groupId> | ||
<artifactId>jakarta.servlet-api</artifactId> | ||
<version>5.0.0</version> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI: This comment is probably really important for you guys as well: spring-projects/spring-framework#29435 (comment) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you see any need for servlet 5 support instead of going to servlet 6? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We (my company) probably have to go to Servlet 6 now as well, because of SB 3.0 and the EoL Announcement of Tomcat 10.0.x but I'm not sure what the best base-line would be for Vaadin to be honest - you have a little more servlet container / application server to consider. Like Jürgen said in the mentioned comment in the Spring Framework, Jetty 12 isn't GA at and therefore Jetty 11 still uses Servlet 5 |
||
<version>6.0.0</version> | ||
</dependency> | ||
|
||
<dependency> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to clarify for myself: this is needed to run all the tests within the same test module with either tomcat or jetty, right? But jetty 11 itself seems to be compatible with the Servlet 6.0, as you bumped jakarta.servlet-api version in the root pom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default Spring Boot runs on Tomcat. This makes it run on Jetty instead. Spring Boot 3 is still compatible with servlet 5, i.e. Jetty 11 as there is nothing that uses the new Servlet 6 API in Flow or in Spring Boot 3