chore: Upgrade to Spring Boot 3 RC2 #15098
Conversation
project-bot
bot
added this to Iteration Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
Artur-
force-pushed
the
springboot-3rc2
branch
from
85d8c55
to
1976968
Compare
Artur-
force-pushed
the
springboot-3rc2
branch
from
4cbe4e3
to
b331d9c
Compare
…hrough the proxy test
| @@ -235,7 +235,7 @@ | |||
| <dependency> | |||
| <groupId>jakarta.servlet</groupId> | |||
| <artifactId>jakarta.servlet-api</artifactId> | |||
| <version>5.0.0</version> | |||
There was a problem hiding this comment.
FYI: This comment is probably really important for you guys as well: spring-projects/spring-framework#29435 (comment)
There was a problem hiding this comment.
Do you see any need for servlet 5 support instead of going to servlet 6?
There was a problem hiding this comment.
We (my company) probably have to go to Servlet 6 now as well, because of SB 3.0 and the EoL Announcement of Tomcat 10.0.x but I'm not sure what the best base-line would be for Vaadin to be honest - you have a little more servlet container / application server to consider. Like Jürgen said in the mentioned comment in the Spring Framework, Jetty 12 isn't GA at and therefore Jetty 11 still uses Servlet 5
|
Kudos, SonarCloud Quality Gate passed!
|
| </dependency> | ||
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-jetty</artifactId> |
There was a problem hiding this comment.
Just want to clarify for myself: this is needed to run all the tests within the same test module with either tomcat or jetty, right? But jetty 11 itself seems to be compatible with the Servlet 6.0, as you bumped jakarta.servlet-api version in the root pom?
There was a problem hiding this comment.
By default Spring Boot runs on Tomcat. This makes it run on Jetty instead. Spring Boot 3 is still compatible with servlet 5, i.e. Jetty 11 as there is nothing that uses the new Servlet 6 API in Flow or in Spring Boot 3
As Spring Boot now uses Tomcat 10.1, we cannot mix Jetty 11 (servlet 5) and Tomcat 10.1 (servlet 6) in the same test modules so they are all run with Jetty 11 for now.