Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use js for lit-renderer-test-component #4127

Merged
merged 4 commits into from
Nov 17, 2022
Merged

test: use js for lit-renderer-test-component #4127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be60046
test: use js for lit-renderer-test-component
tomivirkki Nov 17, 2022
8689090
chore: clean up log filtering
tomivirkki Nov 17, 2022
664bb44
revert "test: use js for lit-renderer-test-component"
tomivirkki Nov 17, 2022
5da12eb
Revert "revert "test: use js for lit-renderer-test-component""
tomivirkki Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 9 additions & 12 deletions ...s/frontend/lit-renderer-test-component.ts → ...s/frontend/lit-renderer-test-component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,15 @@
import { html, LitElement } from 'lit';
import { customElement, property } from 'lit/decorators.js';

type ItemModel = { item: any; index: number };

type Renderer = (root: HTMLElement, _: HTMLElement, model: ItemModel) => void;

@customElement('lit-renderer-test-component')
export class LitRendererTestComponent extends LitElement {
@property()
renderer?: Renderer;
static get properties() {
return {
renderer: { type: Object },

@property()
detailsRenderer?: Renderer;
detailsRenderer: { type: Object },

@property({ type: Array })
items: string[] = [];
items: { type: Array }
};
}

createRenderRoot() {
return this;
Expand Down Expand Up @@ -62,3 +57,5 @@ export class LitRendererTestComponent extends LitElement {
`;
}
}

customElements.define('lit-renderer-test-component', LitRendererTestComponent);
2 changes: 1 addition & 1 deletion ...ion-tests/src/main/java/com/vaadin/flow/data/renderer/tests/LitRendererTestComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
import elemental.json.JsonValue;

@Tag("lit-renderer-test-component")
@JsModule("lit-renderer-test-component.ts")
@JsModule("lit-renderer-test-component.js")
public class LitRendererTestComponent extends Div
implements HasDataProvider<String> {

Expand Down
5 changes: 2 additions & 3 deletions ...ow-integration-tests/src/test/java/com/vaadin/flow/data/renderer/tests/LitRendererIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,8 @@ public void shouldSupportRendererInstanceSpecificProperties() {

private String getClientCallableLogArray() {
String message = getLogEntries(Level.WARNING).stream()
// Discard lit-element warning lines
.filter(m -> !m.getMessage().contains(
"The main 'lit-element' module entrypoint is deprecated."))
// Discard all but event messages
.filter(m -> m.getMessage().contains("event:"))
// Return first warning message in console
.findFirst().get().getMessage();
return message.split("\"")[1];
Expand Down