Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use js for lit-renderer-test-component #4127

Merged
merged 4 commits into from Nov 17, 2022
Merged

test: use js for lit-renderer-test-component #4127

merged 4 commits into from Nov 17, 2022

Conversation

tomivirkki
Copy link
Member

No description provided.

web-padawan
web-padawan approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should have a test in Flow that would check that @property() works instead.

@tomivirkki
Copy link
Member Author

vaadin/flow#15165 most probably fixes the root issue. If the snapshots builds pass fine, I'll repurpose this PR only to include the log filter cleanup.

@sissbruecker sissbruecker reopened this Nov 17, 2022
@web-padawan
Copy link
Member

The snapshot build passed, @tomivirkki please update the PR.

@tomivirkki tomivirkki changed the title test: use js for lit-renderer-test-component test: clean up LitRendererIT log filtering Nov 17, 2022
@tomivirkki tomivirkki changed the title test: clean up LitRendererIT log filtering test: use js for lit-renderer-test-component Nov 17, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit eaa1aa6 into master Nov 17, 2022
@web-padawan web-padawan deleted the test/fix-lit-renderer-tests branch November 17, 2022 12:08
@vaadin-bot
Copy link
Collaborator

Hi @tomivirkki and @web-padawan, when i performed cherry-pick to this commit to 23.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick eaa1aa6
error: could not apply eaa1aa6... test: use JS for lit-renderer-test-component (#4127)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

tomivirkki added a commit that referenced this pull request Nov 17, 2022
@tomivirkki
test: use JS for lit-renderer-test-component (#4127)
e065252
@tomivirkki tomivirkki mentioned this pull request Nov 17, 2022
Merged
web-padawan pushed a commit that referenced this pull request Nov 17, 2022
@tomivirkki
test: use JS for lit-renderer-test-component (#4127) (#4141)
5d31a27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
need to pick manually 23.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomivirkki @web-padawan @vaadin-bot @sissbruecker