Prevent subcomponent type styles from overriding the primary component #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisdano
added
affects: banner
Package: Footer
Package: Sidenav
Type: Bug
mejiaj
approved these changes
Dec 10, 2019
| @@ -7,6 +7,10 @@ | |||
| font-size: font-size($theme-banner-font-family, "3xs"); | |||
| padding-bottom: units(0); | |||
| } | |||
|
|
|||
| .usa-accordion { | |||
| @include typeset($theme-banner-font-family); | |||
There was a problem hiding this comment.
@thisisdano, this is under the assumption that usa-accordion font could be overridden right?
There was a problem hiding this comment.
yup — this can be set with the $theme-accordion-font-family theme variable — but in this instance we don't want that value to render, instead we want to render the value of $theme-banner-font-family
because those values happened to be the same in earlier testing, we didn't catch this
This was referenced Dec 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now components reliably respect their font settings. Setting values like
$theme-footer-font-familyshould set the font face for the entire component, but some CSS specificity quirks were overriding these values in some instances. Now, setting a component's font face works as expected, with no secret overrides.