Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accordion typeface overrides usa-banner typeface #3127

Closed
thisisdano opened this issue Oct 8, 2019 · 2 comments
Closed

accordion typeface overrides usa-banner typeface #3127

thisisdano opened this issue Oct 8, 2019 · 2 comments
Assignees
@thisisdano
Labels
Package: Sidenav Type: Bug A problem in the code
Projects
USWDS Sprint Board

Comments

@thisisdano
Copy link
Member

The banner component should get the ui family by default, but it font face is getting overridden by the usa-accordion font-face (body by default). We need some more specific CSS in the banner to force the banner to use the proper face.

Something like the following could do it:

.usa-banner .usa-accordion {
  @include typeset('ui');
}
@thisisdano thisisdano added the Type: Bug A problem in the code label Oct 8, 2019
@thisisdano thisisdano self-assigned this Oct 8, 2019
@thisisdano
Copy link
Member Author

I'm also seeing this in usa-nav

@thisisdano thisisdano added this to the Release 2.3.2 milestone Dec 3, 2019
@thisisdano thisisdano added this to Upcoming in USWDS Sprint Board Dec 3, 2019
@thisisdano thisisdano moved this from Upcoming to Sprint backlog in USWDS Sprint Board Dec 5, 2019
@thisisdano thisisdano moved this from Sprint backlog to In progress in USWDS Sprint Board Dec 5, 2019
@thisisdano thisisdano moved this from In progress to Review in USWDS Sprint Board Dec 6, 2019
@thisisdano
Copy link
Member Author

Fixed by #3253

USWDS Sprint Board automation moved this from Review to Done Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisdano thisisdano

Labels
Package: Sidenav Type: Bug A problem in the code
Projects
USWDS Sprint Board
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thisisdano