Change direction of dropdown arrow when opened #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm — I'm not seeing this in action here: https://federalist-proxy.app.cloud.gov/preview/uswds/uswds/dw-grid-important/components/preview/header--default.html Am I missing something? |
|
@thisisdano It looks like you may be on the wrong branch? You linked to dw-grid-important. But the change is on https://federalist-proxy.app.cloud.gov/preview/uswds/uswds/sg-header-arrow/components/preview/header--default.html |
|
Oooof. Poor tab management skills. |
thisisdano
approved these changes
Feb 25, 2019
|
Nice work — sorry for the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
Closes #2616
Added up arrow images assets.
Swapped out down arrow for up arrow when the menu is expanded.