New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start using SSLContext.minimum|maximum_version when available #2220
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2220 +/- ##
===========================================
- Coverage 100.00% 99.27% -0.73%
===========================================
Files 25 25
Lines 2466 2484 +18
===========================================
Hits 2466 2466
- Misses 0 18 +18
Continue to review full report at Codecov.
|
42531ef
to
8189636
Compare
8189636
to
d881cc4
Compare
You can now remove the Python 3.6 specific code! This will make this easier |
Definitely! I have some local changes that rebased this on |
fa03286
to
7907e2b
Compare
I think this is ready for review functionality-wise! For future reviewers please rebase merge this PR as it contains multiple features. |
And now the feature is documented too, ready for a full review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is great. I've only looked at the code (not the tests or docs) on my phone, hopefully this initial review is still useful.
There are two legitimate coverage issues, can you please take a look?
4824360
to
316f735
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Feel free to merge after looking at my only comment.
316f735
to
9845c2e
Compare
Closes #2110
Closes #2373
minimum_version
andmaximum_version
converters to the PyOpenSSL and SecureTransport SSLContext implementationsFixing the test suite for the new deprecation messagessl_minimum_version
andssl_maximum_version
, removing documentation aboutssl_version
.Creating an issue about deprecatingssl_version
once Python 3.6 support is dropped. Right now we're in a soft deprecation as if we were emitting deprecation warnings now it'd make life hard for any library supporting Python 3.6+ and using the option.