I guess VerifiedHTTPSConnection is required

urllib3 · Jun 21, 2021 · 8189636 · 8189636
1 parent d302f57
commit 8189636
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/urllib3/connectionpool.py b/src/urllib3/connectionpool.py
@@ -44,13 +44,13 @@
 from .util.request import set_file_position
 from .util.response import assert_header_parsing
 from .util.retry import Retry
+from .util.ssl_ import _TYPE_TLS_VERSION
 from .util.ssl_match_hostname import CertificateError
 from .util.timeout import Timeout
 from .util.url import Url, _encode_target
 from .util.url import _normalize_host as normalize_host
 from .util.url import parse_url
 from .util.util import to_str
-from .util.ssl_ import _TYPE_TLS_VERSION
 
 if TYPE_CHECKING:
 
@@ -897,8 +897,8 @@ def __init__(
         key_password: Optional[str] = None,
         ca_certs: Optional[str] = None,
         ssl_version: Optional[Union[int, str]] = None,
-        ssl_minimum_version: Optional[_TYPE_TLS_VERSION]=None,
-        ssl_maximum_version: Optional[_TYPE_TLS_VERSION]=None,
+        ssl_minimum_version: Optional[_TYPE_TLS_VERSION] = None,
+        ssl_maximum_version: Optional[_TYPE_TLS_VERSION] = None,
         assert_hostname: Optional[Union[str, "Literal[False]"]] = None,
         assert_fingerprint: Optional[str] = None,
         ca_cert_dir: Optional[str] = None,
@@ -936,7 +936,7 @@ def _prepare_conn(self, conn: HTTPSConnection) -> HTTPConnection:
         and establish the tunnel if proxy is used.
         """
 
-        if isinstance(conn, HTTPSConnection):
+        if isinstance(conn, VerifiedHTTPSConnection):
             conn.set_cert(
                 key_file=self.key_file,
                 key_password=self.key_password,

diff --git a/src/urllib3/poolmanager.py b/src/urllib3/poolmanager.py
@@ -33,9 +33,9 @@
 from .util.connection import SocketOptions
 from .util.proxy import connection_requires_http_tunnel
 from .util.retry import Retry
+from .util.ssl_ import _TYPE_TLS_VERSION
 from .util.timeout import Timeout
 from .util.url import Url, parse_url
-from .util.ssl_ import _TYPE_TLS_VERSION
 
 if TYPE_CHECKING:
     import ssl

diff --git a/src/urllib3/request.py b/src/urllib3/request.py
@@ -68,7 +68,6 @@ def request(
         body: Optional[HTTPBody] = None,
         fields: Optional[_TYPE_FIELDS] = None,
         headers: Optional[Mapping[str, str]] = None,
-        body: Optional[HTTPBody] = None,
         **urlopen_kw: Any,
     ) -> BaseHTTPResponse:
         """