Rename Retry options and defaults #2000
Conversation
sethmlarson
force-pushed
the
rename-retry-options
branch
2 times, most recently
from
a642692
to
43db004
Compare
| # and if so we pass the deprecated 'method_whitelist' otherwise | ||
| # we use 'method_allowlist'. Remove in v2.0 | ||
| if "method_whitelist" not in kw and "method_allowlist" not in kw: | ||
| if "method_whitelist" in self.__dict__: |
There was a problem hiding this comment.
I'm doing this instead of hasattr(self, "method_whitelist") because that triggers a getattr() call. Thanks Hynek for the blog post. If there's a better way, let me know :)
| @@ -0,0 +1,428 @@ | |||
| import mock | |||
There was a problem hiding this comment.
This is literally a copy-paste of test_retry.py with extra asserts about deprecated options. Done so that we can move along with test_retry.py without having to think about deprecations much but also ensure that everything that used to work still does.
We'll remove this from master once we cut a v1.26 branch
Codecov Report
@@ Coverage Diff @@
## master #2000 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 2187 2233 +46
=========================================
+ Hits 2187 2233 +46
Continue to review full report at Codecov.
|
sethmlarson
force-pushed
the
rename-retry-options
branch
2 times, most recently
from
d6676a9
to
ef831d4
Compare
sethmlarson
force-pushed
the
rename-retry-options
branch
from
ef831d4
to
77dd9d8
Compare
|
This is great, will feel good to purge this in v2.0 :) |
|
Thanks for review comments @sigmavirus24 and @shazow, rerequesting reviews from both of yall with the changes :) |
src/urllib3/util/retry.py
Outdated
| _Default = object() | ||
|
|
||
|
|
||
| class RetryMeta(type): |
There was a problem hiding this comment.
Optional nit: Maybe RetryDeprecations or RetryWarnings would be more descriptive.
There was a problem hiding this comment.
I'm going to pass on this one since it's "Retry metaclass", maybe I should make the class private though.
There was a problem hiding this comment.
Maybe I just haven't written Python in too long, it has become weird to me to add type hinting into the name of things (rather than describe what they do).
Co-authored-by: Andrey Petrov <shazow@gmail.com>
Co-authored-by: Andrey Petrov <shazow@gmail.com>
Co-authored-by: Andrey Petrov <shazow@gmail.com>
|
@sigmavirus24 git init deprecatelib3 |
|
Tag line: break shit more often 🤘 |
|
DEPRECATE EVERYTHING / FEAR NOTHING! |
|
Thanks for the reviews @shazow and @sigmavirus24! |
Closes #1916
Still need to add some test cases on how setting both options interacts.