use allowed_method option instead of method_whitelist #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to use new retry option name 'allowed_methods' instead of 'method_whitelist'
|
Kudos, SonarCloud Quality Gate passed!
|
Konboi
approved these changes
Dec 14, 2021
| @@ -39,7 +39,7 @@ def __init__(self, base_url: str = "", session: Session = None, test_runner: str | |||
| if session is None: | |||
| strategy = Retry( | |||
| total=3, | |||
| method_whitelist=["GET", "PUT", "PATCH", "DELETE"], | |||
| allowed_methods=["GET", "PUT", "PATCH", "DELETE"], | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To suppress DeprecationWarning.
I explicitly specify the version of urllib3 that the request package depends on as 1.26 or later. This is the version in which
allowed_methodswas introduced.Also, the requests library has been updated to support urllib3 v1.26 since version 2.25, so I specify that as well.
https://github.com/psf/requests/blob/main/HISTORY.md#2250-2020-11-11
These changes meet our version requirements to support python 3.5.