Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle httplib implementations that don't set _tunnel_host #1527

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Handle httplib implementations that don't set _tunnel_host #1527

merged 1 commit into from
Jan 24, 2019

Commits on Jan 24, 2019

  1. Handle httplib implementations that don't set _tunnel_host 

    urllib3 removed support for Python versions before 2.7 in a previous
pull request, unfortunately, this broke environments that use a
different implementation of httplib than the one in Python's standard
library as well. This includes Google App Engine's urlfetch-based
implementation
(https://github.com/GoogleCloudPlatform/python-compat-runtime/blob/master/appengine-compat/exported_appengine_sdk/google/appengine/dist27/gae_override/httplib.py#L362)

This pull request is nearly identical to urllib3#1504 which was
closed due to its author not responding to comments.

Fixes urllib3#1503
    @jpevarnek
    jpevarnek committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    c42c8c6 View commit details
    Browse the repository at this point in the history