Handle httplib implementations that don't set _tunnel_host #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urllib3 removed support for Python versions before 2.7 in a previous pull request, unfortunately, this broke environments that use a different implementation of httplib than the one in Python's standard library as well. This includes Google App Engine's urlfetch-based implementation (https://github.com/GoogleCloudPlatform/python-compat-runtime/blob/master/appengine-compat/exported_appengine_sdk/google/appengine/dist27/gae_override/httplib.py#L362) This pull request is nearly identical to urllib3#1504 which was closed due to its author not responding to comments. Fixes urllib3#1503
Codecov Report
@@ Coverage Diff @@
## master #1527 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 22 22
Lines 1809 1809
=======================================
Hits 1808 1808
Misses 1 1
Continue to review full report at Codecov.
|
theacodes
approved these changes
Jan 24, 2019
|
Thanks for this change! 🎉 |
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urllib3 removed support for Python versions before 2.7 in a previous
pull request, unfortunately, this broke environments that use a
different implementation of httplib than the one in Python's standard
library as well. This includes Google App Engine's urlfetch-based
implementation
(https://github.com/GoogleCloudPlatform/python-compat-runtime/blob/master/appengine-compat/exported_appengine_sdk/google/appengine/dist27/gae_override/httplib.py#L362)
This pull request is nearly identical to #1504 which was
closed due to its author not responding to comments.
Fixes #1503