Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1] Add urfave_cli_no_docs build tag #1383

Merged
merged 3 commits into from May 5, 2022
Merged

[v1] Add urfave_cli_no_docs build tag #1383

merged 3 commits into from May 5, 2022

Commits on May 4, 2022

  1. Move some test helpers from docs_test to fish_test 

    This is in preparation to make docs optional.

Backported from commit aabfea8

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed May 4, 2022
    Copy the full SHA
    ba801d7 View commit details
    Browse the repository at this point in the history

  2. Add urfave_cli_no_docs build tag 

    This removes the resulting binary dependency on cpuguy83/md2man and
russross/blackfriday, which saves more than 400 KB (more than 300 KB
once stripped) from the resulting binary.

Document this in README.

(cherry picked from commit 49e43be)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed May 4, 2022
    Copy the full SHA
    fc47b1a View commit details
    Browse the repository at this point in the history

  3. ci: test newly added tag 

    We run test with the tag set (to make sure nothing is broken).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed May 4, 2022
    Copy the full SHA
    2930925 View commit details
    Browse the repository at this point in the history