[v1] Add urfave_cli_no_docs build tag #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2022
|
Ah, it seems I have broken CI with an earlier PR. |
|
Draft until I fix v1 CI (in progress). |
kolyshkin
changed the title
|
Draft until #1384 is merged. |
Merged
This is in preparation to make docs optional. Backported from commit aabfea8 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This removes the resulting binary dependency on cpuguy83/md2man and russross/blackfriday, which saves more than 400 KB (more than 300 KB once stripped) from the resulting binary. Document this in README. (cherry picked from commit 49e43be) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
We run test with the tag set (to make sure nothing is broken). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
@meatballhat this one is ready to go! |
|
@kolyshkin did you want to take care of taking the PR out of Draft mode and editing out the |
kolyshkin
changed the title
Sorry, forgot to remove Can you please make a release once this is merged? |
meatballhat
approved these changes
May 5, 2022
This was referenced May 27, 2022
Merged
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Jun 14, 2022
Ref: ettps://github.com/urfave/cli/pull/1383 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Jun 14, 2022
From urfave/cli#1383 : > This removes the resulting binary dependency on cpuguy83/md2man and > russross/blackfriday (and a few more packages imported by those), > which saves more than 400 KB (more than 300 KB > once stripped) from the resulting binary. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Jun 14, 2022
From urfave/cli#1383 : > This removes the resulting binary dependency on cpuguy83/md2man and > russross/blackfriday (and a few more packages imported by those), > which saves more than 400 KB (more than 300 KB > once stripped) from the resulting binary. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Jun 14, 2022
From urfave/cli#1383 : > This removes the resulting binary dependency on cpuguy83/md2man and > russross/blackfriday (and a few more packages imported by those), > which saves more than 400 KB (more than 300 KB > once stripped) from the resulting binary. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Jun 14, 2022
From urfave/cli#1383 : > This removes the resulting binary dependency on cpuguy83/md2man and > russross/blackfriday (and a few more packages imported by those), > which saves more than 400 KB (more than 300 KB > once stripped) from the resulting binary. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Jun 15, 2022
From urfave/cli#1383 : > This removes the resulting binary dependency on cpuguy83/md2man and > russross/blackfriday (and a few more packages imported by those), > which saves more than 400 KB (more than 300 KB > once stripped) from the resulting binary. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to k3s-io/k3s
that referenced
this pull request
Jun 15, 2022
From urfave/cli#1383 : > This removes the resulting binary dependency on cpuguy83/md2man and > russross/blackfriday (and a few more packages imported by those), > which saves more than 400 KB (more than 300 KB > once stripped) from the resulting binary. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to k3s-io/k3s
that referenced
this pull request
Jun 15, 2022
From urfave/cli#1383 : > This removes the resulting binary dependency on cpuguy83/md2man and > russross/blackfriday (and a few more packages imported by those), > which saves more than 400 KB (more than 300 KB > once stripped) from the resulting binary. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to k3s-io/k3s
that referenced
this pull request
Jun 15, 2022
From urfave/cli#1383 : > This removes the resulting binary dependency on cpuguy83/md2man and > russross/blackfriday (and a few more packages imported by those), > which saves more than 400 KB (more than 300 KB > once stripped) from the resulting binary. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Add urfave_cli_no_docs build tag
This removes the resulting binary dependency on cpuguy83/md2man and
russross/blackfriday (and a few more packages imported by those),
which saves more than 400 KB (more than 300 KB
once stripped) from the resulting binary.
Which issue(s) this PR fixes:
none (although see some discussions in e.g. #1055)
Special notes for your reviewer:
This is a backport of #1375 to v1 branch.
Testing
Unit tests with this tag set are added to GHA CI (see last commit).
Release Notes