Skip to content

Commit

Permalink
Merge pull request #1598 from urfave/rm-gen
Browse files Browse the repository at this point in the history
Remove flag type generation code
  • Loading branch information
meatballhat committed Nov 27, 2022
2 parents 510c407 + df2f6f8 commit 26b286a
Show file tree
Hide file tree
Showing 18 changed files with 3 additions and 771 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,10 @@ jobs:
env:
GFLAGS: -tags urfave_cli_no_docs
- run: make test
- run: make -C cmd/urfave-cli-genflags
- run: make check-binary-size
env:
GFLAGS: -tags urfave_cli_no_docs
- run: make check-binary-size
- run: make yamlfmt
- if: matrix.go == '1.19.x' && matrix.os == 'ubuntu-latest'
run: make generate
- run: make diffcheck
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
.envrc
.idea
/.local/
/cmd/urfave-cli-genflags/urfave-cli-genflags
/site/
coverage.txt
internal/*/built-example
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
GO_RUN_BUILD := go run internal/build/build.go

.PHONY: all
all: generate vet test check-binary-size gfmrun yamlfmt
all: generate vet test check-binary-size gfmrun

# NOTE: this is a special catch-all rule to run any of the commands
# defined in internal/build/build.go with optional arguments passed
Expand Down
2 changes: 0 additions & 2 deletions cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,3 @@
// app.Run(os.Args)
// }
package cli

//go:generate make -C cmd/urfave-cli-genflags run
28 changes: 0 additions & 28 deletions cmd/urfave-cli-genflags/Makefile

This file was deleted.

15 changes: 0 additions & 15 deletions cmd/urfave-cli-genflags/README.md

This file was deleted.

87 changes: 0 additions & 87 deletions cmd/urfave-cli-genflags/generated.gotmpl

This file was deleted.

29 changes: 0 additions & 29 deletions cmd/urfave-cli-genflags/generated_altsrc.gotmpl

This file was deleted.

42 changes: 0 additions & 42 deletions cmd/urfave-cli-genflags/generated_test.gotmpl

This file was deleted.

15 changes: 0 additions & 15 deletions cmd/urfave-cli-genflags/go.mod

This file was deleted.

14 changes: 0 additions & 14 deletions cmd/urfave-cli-genflags/go.sum

This file was deleted.

0 comments on commit 26b286a

Please sign in to comment.