Remove flag type generation code

and related tooling, given all of it has been replaced by ✨ generics magic ✨ Connected to #833
urfave · Nov 27, 2022 · df2f6f8 · df2f6f8
1 parent 04736d1
commit df2f6f8
Show file tree

Hide file tree

Showing 18 changed files with 3 additions and 771 deletions.
diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml
@@ -34,12 +34,10 @@ jobs:
         env:
           GFLAGS: -tags urfave_cli_no_docs
       - run: make test
-      - run: make -C cmd/urfave-cli-genflags
       - run: make check-binary-size
         env:
           GFLAGS: -tags urfave_cli_no_docs
       - run: make check-binary-size
-      - run: make yamlfmt
       - if: matrix.go == '1.19.x' && matrix.os == 'ubuntu-latest'
         run: make generate
       - run: make diffcheck

diff --git a/.gitignore b/.gitignore
@@ -5,7 +5,6 @@
 .envrc
 .idea
 /.local/
-/cmd/urfave-cli-genflags/urfave-cli-genflags
 /site/
 coverage.txt
 internal/*/built-example

diff --git a/Makefile b/Makefile
@@ -7,7 +7,7 @@
 GO_RUN_BUILD := go run internal/build/build.go
 
 .PHONY: all
-all: generate vet test check-binary-size gfmrun yamlfmt
+all: generate vet test check-binary-size gfmrun
 
 # NOTE: this is a special catch-all rule to run any of the commands
 # defined in internal/build/build.go with optional arguments passed

diff --git a/cli.go b/cli.go
@@ -21,5 +21,3 @@
 //		app.Run(os.Args)
 //	}
 package cli
-
-//go:generate make -C cmd/urfave-cli-genflags run
diff --git a/cmd/urfave-cli-genflags/Makefile b/cmd/urfave-cli-genflags/Makefile
diff --git a/cmd/urfave-cli-genflags/README.md b/cmd/urfave-cli-genflags/README.md
diff --git a/cmd/urfave-cli-genflags/generated.gotmpl b/cmd/urfave-cli-genflags/generated.gotmpl
diff --git a/cmd/urfave-cli-genflags/generated_altsrc.gotmpl b/cmd/urfave-cli-genflags/generated_altsrc.gotmpl
diff --git a/cmd/urfave-cli-genflags/generated_test.gotmpl b/cmd/urfave-cli-genflags/generated_test.gotmpl
diff --git a/cmd/urfave-cli-genflags/go.mod b/cmd/urfave-cli-genflags/go.mod
diff --git a/cmd/urfave-cli-genflags/go.sum b/cmd/urfave-cli-genflags/go.sum