Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct listenAddress for Karma on node 18+ #13968

Merged

Conversation

JasonElkin
Copy link
Contributor

@JasonElkin JasonElkin commented Mar 14, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

From Node.js 17 DNS resolution is different, causing the Karma server to listen to the wrong address by default. This breaks Umbraco's gulp test tasks and default gulp build.

Telling the karma server to listen on :: fixes the problem - as per the issue on the Karma repo. This change is backwards compatible down to (at least) Node.js v14 so doesn't change version requirements for Umbraco 馃帀

To test: run gulp build from /src/Umbraco.Web.UI.Client on any version from Node.js from 14+

I've tested on 14, 16, 18 and 19

Once this is merged, it would be worth checking if HQ can bump the Node.js version in the pipelines to latest LTS.

@github-actions
Copy link

github-actions bot commented Mar 14, 2023

Hi there @JasonElkin, thank you for this contribution! 馃憤

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 馃挕 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 馃 馃檪

@nul800sebastiaan nul800sebastiaan merged commit 50c4f8c into umbraco:contrib Mar 15, 2023
14 checks passed
@nul800sebastiaan
Copy link
Member

Thanks @JasonElkin - works on my machine now as well!
FYI: I didn't add an Umbraco version to this, because it's not relevant for anyone but contributors / build servers.

@nul800sebastiaan
Copy link
Member

Cherry picked for the v10 branch as well so it's easier to work on for everyone, thanks again @JasonElkin! 53c547f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants