Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the version requirements for running the current back office #13940

Merged
merged 3 commits into from Mar 15, 2023

Conversation

richarth
Copy link
Contributor

@richarth richarth commented Mar 9, 2023

Building the current version of the back office is only supported on Node v16 and earlier so have updated the docs to reflect that.

Building the current version of the back office is only supported on Node v16 and earlier so have updated the docs to reflect that.
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Hi there @richarth, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

For v11 you now need to be running .Net 7 and VS 2022 so have updated the docs to reflect that.
@richarth richarth changed the title Updated the maximum Node version supported Updated the version requirements for the current back office Mar 9, 2023
@richarth richarth changed the title Updated the version requirements for the current back office Updated the version requirements for running the current back office Mar 9, 2023
@JasonElkin JasonElkin self-assigned this Mar 9, 2023
Copy link
Contributor

@JasonElkin JasonElkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @richarth, thanks for updating this, it is an interesting one...

Node v16.19.1 is required to run the tests, but just running the build-only gulp tasks works all the way up to v19.7.0 (current latest version).

When running the frontend build as part of the default (.NET/C#) project build the tests are skipped, so there is still no upper limit when it comes to "building" Umbraco from source.

If you think it would be helpful, perhaps you could add a separate note in here about the node version required for running the tests?

.github/BUILD.md Outdated Show resolved Hide resolved
.github/BUILD.md Outdated Show resolved Hide resolved
@JasonElkin
Copy link
Contributor

Assuming this PR gets merged, the gulp tests (and default gulp build) will then work on all Node.js versions from 14 to 19.

Co-authored-by: Jason Elkin <jasonelkin86@gmail.com>
@nul800sebastiaan
Copy link
Member

Thanks both @richarth for helping with the updates and @JasonElkin for fixing #13968 so that the requirements span a nice wide range of node versions again. Much nicer to be able to support the latest LTS of node!

@nul800sebastiaan nul800sebastiaan merged commit 6594c13 into umbraco:contrib Mar 15, 2023
3 of 5 checks passed
@nul800sebastiaan
Copy link
Member

FYI: I've not put any additional labels on, this is an update that only affects contributors, not an actual Umbraco release.

Thanks again!

@JasonElkin JasonElkin removed their assignment Mar 15, 2023
@richarth richarth deleted the build-docs-node-versions branch March 15, 2023 17:17
@richarth
Copy link
Contributor Author

Thanks @JasonElkin and @nul800sebastiaan for fixing this. It's going to make getting started contributing much smoother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants