Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamically linking against system double-conversion library #508

Merged
merged 6 commits into from Feb 17, 2022
Merged

Support dynamically linking against system double-conversion library #508

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9c4501
Add env vars to build with system double-conversion
musicinmybrain Feb 16, 2022
9425d24
Improved splitting for new env vars
musicinmybrain Feb 16, 2022
ce30f22
Document build options in README.md
musicinmybrain Feb 16, 2022
bb796d6
External dconv improvement
musicinmybrain Feb 16, 2022
0268e5b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 16, 2022
9ee6cbb
Filter out any empty strings from dconv_includes
musicinmybrain Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions setup.py
View file
Open in desktop
Expand Up @@ -25,9 +25,15 @@
"./lib/ultrajsonenc.c",
"./lib/ultrajsondec.c",
],
include_dirs=["./python", "./lib", "./deps/double-conversion/double-conversion"],
include_dirs=["./python", "./lib"]
+ environ.get(
"UJSON_BUILD_DC_INCLUDES",
"./deps/double-conversion/double-conversion",
).split(),
extra_compile_args=["-D_GNU_SOURCE"],
extra_link_args=["-lstdc++", "-lm"] + strip_flags,
extra_link_args=["-lstdc++", "-lm"]
+ environ.get("UJSON_BUILD_DC_LIBS", "").split()
musicinmybrain marked this conversation as resolved.
Show resolved Hide resolved
+ strip_flags,
)

with open("python/version_template.h") as f:
Expand Down