Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamically linking against system double-conversion library #508

Merged
merged 6 commits into from Feb 17, 2022
Merged

Support dynamically linking against system double-conversion library #508

merged 6 commits into from Feb 17, 2022

Commits on Feb 16, 2022

  1. Add env vars to build with system double-conversion 

    This fixes ultrajson#376 and is useful to Linux distribution packagers.

New environment variables UJSON_BUILD_DC_INCLUDES and UJSON_BUILD_DC_LIBS allow overriding the include path for double-conversion and adding linker flags for an external double-conversion library. They should generally be used together.
    @musicinmybrain
    musicinmybrain committed Feb 16, 2022
    Copy the full SHA
    c9c4501 View commit details
    Browse the repository at this point in the history

  2. Improved splitting for new env vars

    @musicinmybrain
    musicinmybrain committed Feb 16, 2022
    Copy the full SHA
    9425d24 View commit details
    Browse the repository at this point in the history

  3. Document build options in README.md

    @musicinmybrain
    musicinmybrain committed Feb 16, 2022
    Copy the full SHA
    ce30f22 View commit details
    Browse the repository at this point in the history

  4. External dconv improvement 

    Automatically disable building ./deps/double-conversion when UJSON_BUILD_DC_LIBS is set to a non-empty value.
    @musicinmybrain
    musicinmybrain committed Feb 16, 2022
    Copy the full SHA
    bb796d6 View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Feb 16, 2022
    Copy the full SHA
    0268e5b View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. Filter out any empty strings from dconv_includes

    @musicinmybrain
    musicinmybrain committed Feb 17, 2022
    Copy the full SHA
    9ee6cbb View commit details
    Browse the repository at this point in the history