Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/sampler: Support decision hook #813

Merged
merged 17 commits into from Apr 21, 2020
Merged

core/sampler: Support decision hook #813

merged 17 commits into from Apr 21, 2020
+227 −18

Commits on Apr 4, 2020

  1. Fix unit tests and a sample sampler start.

    @shirchen
    shirchen committed Apr 4, 2020
    Copy the full SHA
    14b1350 View commit details
    Browse the repository at this point in the history

  2. outlines of a zap sampler option

    @shirchen
    shirchen committed Apr 4, 2020
    Copy the full SHA
    c59b269 View commit details
    Browse the repository at this point in the history

  3. Deprecate NewSampler and add a default a nop SamplerHook.

    @shirchen
    shirchen committed Apr 4, 2020
    Copy the full SHA
    e268359 View commit details
    Browse the repository at this point in the history

  4. Nop hook to NewSampler.

    @shirchen
    shirchen committed Apr 4, 2020
    Copy the full SHA
    cefe15e View commit details
    Browse the repository at this point in the history

  5. Add a default nop hook everywhere.

    @shirchen
    shirchen committed Apr 4, 2020
    Copy the full SHA
    1f5cf2c View commit details
    Browse the repository at this point in the history

  6. Add more docs

    @shirchen
    shirchen committed Apr 4, 2020
    Copy the full SHA
    44fe037 View commit details
    Browse the repository at this point in the history

  7. Fix lint and switch back to using NewSampler in a test for cc.

    @shirchen
    shirchen committed Apr 4, 2020
    Copy the full SHA
    25478e6 View commit details
    Browse the repository at this point in the history

  8. Fix comment and add deprecated constructor in a different place for cc.

    @shirchen
    shirchen committed Apr 4, 2020
    Copy the full SHA
    5cc987e View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Simplify default constructor, add a sample event, do not return error 

    for hook.
    @shirchen
    shirchen committed Apr 7, 2020
    Copy the full SHA
    fd20684 View commit details
    Browse the repository at this point in the history

  2. add sampler benchmark for hook.

    @shirchen
    shirchen committed Apr 7, 2020
    Copy the full SHA
    4ae250b View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. lint

    @shirchen
    shirchen committed Apr 8, 2020
    Copy the full SHA
    d48791a View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. Address feedback.

    @shirchen
    shirchen committed Apr 9, 2020
    Copy the full SHA
    3c00734 View commit details
    Browse the repository at this point in the history

  2. lint and fix comments

    @shirchen
    shirchen committed Apr 9, 2020
    Copy the full SHA
    0bc5a78 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2020

  1. Name return values, clarify count hook accounting.

    @shirchen
    shirchen committed Apr 14, 2020
    Copy the full SHA
    8b91fbb View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Check SamplingDecision as a bit field and expand to 32 bits.

    @shirchen
    shirchen committed Apr 21, 2020
    Copy the full SHA
    09045e2 View commit details
    Browse the repository at this point in the history

  2. lint

    @shirchen
    shirchen committed Apr 21, 2020
    Copy the full SHA
    6d960ec View commit details
    Browse the repository at this point in the history

  3. delete confusing assert and more docs

    @shirchen
    shirchen committed Apr 21, 2020
    Copy the full SHA
    ae3e230 View commit details
    Browse the repository at this point in the history