Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable running spotlessCheck with the build task. #5324

Merged
merged 3 commits into from Sep 19, 2022
Merged

Temporarily disable running spotlessCheck with the build task. #5324

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
524b64c
Temporarily disable running spotlessCheck with the build task.
smillst Sep 19, 2022
1fe58f1
Update build.gradle
smillst Sep 19, 2022
a784c6f
Merge branch 'master' into disable-spotless
smillst Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions build.gradle
View file
Open in desktop
Expand Up @@ -156,6 +156,9 @@ allprojects {
}

spotless {
// TODO: Temporarily disable running spotlessCheck with the build task.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the "TODO" be to remove this?
I'm not sure why this is being added.
In the description, should "with the build task" be "within the build task"? I don't follow that.

All that said, if this is necessary temporarily, you can merge it.

Copy link
Member Author

@smillst smillst Sep 19, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just makes ./gradlew build not run spotlessCheck.

I think I fixed the problem test failure in
#5308. So it and #5311 should be able to be merged soon. Once those are merged, we can remove enforceCheck false.

enforceCheck false

format 'misc', {
// define the files to apply `misc` to
target '*.gradle', '*.md', '.gitignore'
Expand Down