Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable running spotlessCheck with the build task. #5324

Merged
merged 3 commits into from Sep 19, 2022

Conversation

smillst
Copy link
Member

@smillst smillst commented Sep 19, 2022

Fixes #5319.

build.gradle Outdated
@@ -156,6 +156,9 @@ allprojects {
}

spotless {
// TODO: Temporarily disable running spotlessCheck with the build task.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the "TODO" be to remove this?
I'm not sure why this is being added.
In the description, should "with the build task" be "within the build task"? I don't follow that.

All that said, if this is necessary temporarily, you can merge it.

Copy link
Member Author

@smillst smillst Sep 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just makes ./gradlew build not run spotlessCheck.

I think I fixed the problem test failure in
#5308. So it and #5311 should be able to be merged soon. Once those are merged, we can remove enforceCheck false.

@smillst smillst merged commit 9997925 into typetools:master Sep 19, 2022
@smillst smillst deleted the disable-spotless branch September 19, 2022 20:19
wmdietl pushed a commit to eisop/checker-framework that referenced this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current master branch doesn't build
2 participants