feat(rule-tester): assert suggestion messages are unique

[JoshuaKGoldberg]

PR Checklist

• Addresses an existing open issue: fixes (partially) Enhancement(rule-tester): assert suggestion messages are unique #8969
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Brings in changes from eslint/eslint#17532. This is pretty much a copy & paste.

[typescript-eslint]

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a6d1af0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx run integration-tests:test

✅ Successfully ran 30 targets

• nx test eslint-plugin --coverage=false
• nx test eslint-plugin
• nx test type-utils --coverage=false
• nx test visitor-keys --coverage=false
• nx test typescript-estree --coverage=false
• nx run types:build
• nx test utils --coverage=false
• nx test typescript-eslint --coverage=false
• nx run repo-tools:postinstall-script
• nx test scope-manager --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test repo-tools --coverage=false
• nx test parser --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test ast-spec --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test typescript-estree
• nx test scope-manager
• nx test utils
• nx test typescript-eslint
• nx test type-utils
• nx test visitor-keys
• nx test repo-tools
• nx test rule-schema-to-typescript-types
• nx test parser
• nx test eslint-plugin-internal
• nx run-many --target=typecheck --parallel
• nx test ast-spec
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[bradzacher]

BREAKING CHANGE:
Adds extra validation to rule-tester.

sir #8969

Per the discussion in that thread, we'd like to not treat this as a breaking change

[auvred]

Oh, looks like rule-tester is not tested in CI:

typescript-eslint/.github/workflows/ci.yml

Lines 168 to 182 in 4858afd

	package:
	[
	'ast-spec',
	'eslint-plugin',
	'eslint-plugin-internal',
	'parser',
	'repo-tools',
	'rule-schema-to-typescript-types',
	'scope-manager',
	'type-utils',
	'typescript-eslint',
	'typescript-estree',
	'utils',
	'visitor-keys',
	]

I also tried to run yarn run test-eslint-base locally and got a bunch of test failures related to deprecated in ESLint v9 stuff. What do you think about syncing tests/eslint-base/eslint-base.test.js and tests/eslint-base/fixtures/* with upstream? It looks like some fixtures have been changed in v9 as well.

[JoshuaKGoldberg]

sir #8969

Per the discussion in that thread, we'd like to not treat this as a breaking change

Oh! I missed that 🤦 excellent. In that case I'll switch this to be against main and consider #8211 as having all required issues blocked. I sent #9002 to start working on ESLint 9 range support on the v8 branch.

The base branch was changed.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	a6d1af0
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/662bb60585ab0c000815b2fb
😎 Deploy Preview	https://deploy-preview-8995--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 91 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[JoshuaKGoldberg]

Oh, looks like rule-tester is not tested in CI:

😂. #9005. Good spot!

tried to run yarn run test-eslint-base locally and got a bunch of test failures related to deprecated in ESLint v9 stuff

Ooh, yes, that too. Since you have it locally - would you be up for filing that? I'm kind of flitting between things.