Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo: Test rule-tester in CI #9005

Open
JoshuaKGoldberg opened this issue Apr 26, 2024 · 1 comment
Open

Repo: Test rule-tester in CI #9005

JoshuaKGoldberg opened this issue Apr 26, 2024 · 1 comment
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for maintainers to take a look

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Splitting out from @auvred's #8995 (comment):

Oh, looks like rule-tester is not tested in CI:

package:
[
'ast-spec',
'eslint-plugin',
'eslint-plugin-internal',
'parser',
'repo-tools',
'rule-schema-to-typescript-types',
'scope-manager',
'type-utils',
'typescript-eslint',
'typescript-estree',
'utils',
'visitor-keys',
]

Whoops! We should... definitely test this in CI, I'd think?

Co-authored-by: @auvred

@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for maintainers to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Apr 26, 2024
@auvred
Copy link
Member

auvred commented Apr 27, 2024

Note: we should run both test and test-eslint-base scripts.

Because for test-eslint-base the different test runner is used (Mocha instead of Jest). This is done so because tests/eslint-base/eslint-base.test.js is copied from upstream.

See also #9011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for maintainers to take a look
Projects
None yet
Development

No branches or pull requests

2 participants