fix(eslint-plugin): [ban-types] update message to suggest object instead of Record<string, unknown>

packages/eslint-plugin/src/rules/ban-types.ts

@@ -3,16 +3,14 @@ import { AST_NODE_TYPES } from '@typescript-eslint/utils';
 
 import * as util from '../util';
 
-type Types = Record<
-  string,
-  | null
-  | false
-  | string
+type Types =
+  | object
   | {
-      message: string;
-      fixWith?: string;
-    }
->;
+      [key: string]: {
+        message: string;
+        fixWith?: string;
+      };
+    };
 
 export type Options = [
   {
@@ -33,9 +31,10 @@ function stringifyNode(
   return removeSpaces(sourceCode.getText(node));
 }
 
-function getCustomMessage(
-  bannedType: null | string | { message?: string; fixWith?: string },
-): string {
+function getCustomMessage(bannedType: {
+  message?: string;
+  fixWith?: string;
+}): string {
   if (bannedType === null) {
     return '';
   }
@@ -86,14 +85,14 @@ const defaultTypes: Types = {
   Object: {
     message: [
       'The `Object` type actually means "any non-nullish value", so it is marginally better than `unknown`.',
-      '- If you want a type meaning "any object", you probably want `Record<string, unknown>` instead.',
+      '- If you want a type meaning "any object", you probably want `object` instead.',
       '- If you want a type meaning "any value", you probably want `unknown` instead.',
     ].join('\n'),
   },
   '{}': {
     message: [
       '`{}` actually means "any non-nullish value".',
-      '- If you want a type meaning "any object", you probably want `Record<string, unknown>` instead.',
+      '- If you want a type meaning "any object", you probably want `object` instead.',
       '- If you want a type meaning "any value", you probably want `unknown` instead.',
       '- If you want a type meaning "empty object", you probably want `Record<string, never>` instead.',
     ].join('\n'),

packages/eslint-plugin/tests/rules/ban-types.test.ts

@@ -388,6 +388,39 @@ let b: Foo<NS.Good>;
         },
       ],
     },
+
+    {
+      code: noFormat`
+declare let j: unknown;
+let m3 = { ...(j as Record<string, never>) };
+      `,
+      output: `
+declare let j: unknown;
+let m3 = { ...(j as object) };
+      `,
+      options: [
+        {
+          types: {
+            'Record<string, never>': {
+              message: 'Use object instead.',
+              fixWith: 'object',
+            },
+          },
+        },
+      ],
+      errors: [
+        {
+          messageId: 'bannedTypeMessage',
+          data: {
+            name: 'Record<string,never>',
+            customMessage: ' Use object instead.',
+          },
+          line: 3,
+          column: 21,
+        },
+      ],
+    },
+
     {
       code: noFormat`
 let foo: {} = {};