Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [ban-types] update message to suggest object instead of Record<string, unknown> #6079

Merged
merged 19 commits into from Dec 7, 2022
Merged

fix(eslint-plugin): [ban-types] update message to suggest object instead of Record<string, unknown> #6079

Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f679c99
fix:fix messages
kmin-jeong Nov 24, 2022
63d0068
fix:fix type record to object
kmin-jeong Nov 29, 2022
faf1ac2
fix:fix record to object
kmin-jeong Nov 29, 2022
ac2f4f1
feat: add test code
kmin-jeong Nov 29, 2022
64f6362
Merge branch 'main' into feat/5949
kmin-jeong Nov 29, 2022
209590c
fix:fix 5 lint error
kmin-jeong Nov 30, 2022
9b8173a
Merge branch 'master' of https://github.com/kmin-jeong/typescript-esl…
kmin-jeong Nov 30, 2022
ecbc138
fix:fix variable name in checkBannedTypes
kmin-jeong Nov 30, 2022
c6bad6b
Merge branch 'main' into feat/5949
kmin-jeong Nov 30, 2022
0b6708e
Merge branch 'feat/5949' of https://github.com/kmin-jeong/typescript-…
kmin-jeong Nov 30, 2022
7fa5ebd
fix:fix lint error lastone
kmin-jeong Nov 30, 2022
8db5ef0
fix: add total types and delete duplication things
kmin-jeong Nov 30, 2022
da8a46e
fix: fix type total to checTypes
kmin-jeong Nov 30, 2022
8aad9de
fix: fix variable names
kmin-jeong Nov 30, 2022
5890f89
fix: fix types elements
kmin-jeong Nov 30, 2022
9e71fcf
fix:fix type Types
kmin-jeong Nov 30, 2022
e2f6ff0
fix: fix messages in object
kmin-jeong Dec 2, 2022
071bd84
Merge branch 'main' into feat/5949
kmin-jeong Dec 2, 2022
6a22bef
Update packages/eslint-plugin/tests/rules/ban-types.test.ts
JoshuaKGoldberg Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/eslint-plugin/src/rules/ban-types.ts
View file
Open in desktop
Expand Up @@ -86,14 +86,14 @@ const defaultTypes: Types = {
Object: {
message: [
'The `Object` type actually means "any non-nullish value", so it is marginally better than `unknown`.',
'- If you want a type meaning "any object", you probably want `Record<string, unknown>` instead.',
'- If you want a type meaning "any object", you probably want `object` instead.',
'- If you want a type meaning "any value", you probably want `unknown` instead.',
].join('\n'),
},
'{}': {
message: [
'`{}` actually means "any non-nullish value".',
'- If you want a type meaning "any object", you probably want `Record<string, unknown>` instead.',
'- If you want a type meaning "any object", you probably want `object` instead.',
'- If you want a type meaning "any value", you probably want `unknown` instead.',
'- If you want a type meaning "empty object", you probably want `Record<string, never>` instead.',
].join('\n'),
Expand Down