feat(experimental-utils): moved types eslint-plugin util to experimental-utils

[detljh]

PR Checklist

• Addresses an existing issue: fixes [Question] Is the types util file exposed in the experimental-utils package? #3305
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Moves over the types util file into the experimental-utils package in eslint-utils

Also had to duplicate packages/eslint-plugin/typings/typescript.d.ts file into packages/experimental-utils/typings/typescript.d.ts as the types util file depended on it. Unsure if there's another way to do this?

[typescript-eslint]

Thanks for the PR, @detljh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[bradzacher]

LGTM - almost there - one suggestion.
Thanks for your contribution!

[bradzacher]

thanks for doing this!

One thing that you missed (I forgot this exists too!) is the test for the isUnsafeAssignment function:

https://github.com/detljh/typescript-eslint/blob/master/packages/eslint-plugin/tests/util/isUnsafeAssignment.test.ts

[bradzacher]

thanks!

[bradzacher]

looks like this needs to be rebased as there are some complex from another change.
once those are resolved we can merge this

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit 09d5ee9. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 16 targets

• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 16.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 16.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 16.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 16.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 16.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types

---

Sent with 💌 from NxCloud.

[bradzacher]

Looks like there is a merge conflict and build failures.
Once that's fixed we can merge this in.
Thanks for all of your work on this!

[netlify]

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 09d5ee9

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61c245b95b0d4d00078439d4

[bradzacher]

This was done in #3658 - a new package, @typescript-eslint/type-utils has been published!