Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(parser): update parser tsx tests to not use eslint #4323

Merged
merged 3 commits into from Dec 20, 2021
Merged

test(parser): update parser tsx tests to not use eslint #4323

merged 3 commits into from Dec 20, 2021

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Dec 17, 2021 •
edited

Overview

Update TSX tests for parser package to use parseForESLint instead of experimental-utils this change should unblock #3317

current test was treated as integration tests, instead of functional tests

@armano2 armano2 added package: parser Issues related to @typescript-eslint/parser tests anything to do with testing labels Dec 17, 2021
@armano2 armano2 self-assigned this Dec 17, 2021
@nx-cloud
Copy link

nx-cloud bot commented Dec 17, 2021 •
edited

☁️ Nx Cloud Report

CI ran the following commands for commit f7949b4. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 44 targets

Sent with 💌 from NxCloud.

@typescript-eslint

This comment has been minimized.

Sign in to view
@netlify
Copy link

netlify bot commented Dec 17, 2021 •
edited

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: f7949b4

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61c001063d1c1400075705ea

armano2
armano2 commented Dec 17, 2021
View reviewed changes
packages/parser/tests/tools/ts-error-serializer.ts
import type { Plugin } from 'pretty-format';
import { TSError } from '@typescript-eslint/typescript-estree/dist/node-utils';

export const serializer: Plugin = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is copy of serializer from typescript-estree, we can't just inport it as sertializers are not compiled/exposed

@codecov
Copy link

codecov bot commented Dec 17, 2021 •
edited

Codecov Report

Merging #4323 (f7949b4) into main (9f58eab) will increase coverage by 1.47%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##             main    #4323      +/-   ##
==========================================
+ Coverage   92.73%   94.21%   +1.47%     
==========================================
  Files         335      154     -181     
  Lines       11542     8147    -3395     
  Branches     3289     2600     -689     
==========================================
- Hits        10704     7676    -3028     
+ Misses        364      266      -98     
+ Partials      474      205     -269
Flag Coverage Δ
unittest 94.21% <95.00%> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts 97.18% <ø> (ø)
...kages/eslint-plugin/src/rules/no-empty-function.ts 80.00% <ø> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts 76.33% <ø> (ø)
packages/eslint-plugin/src/rules/semi.ts 92.85% <ø> (ø)
...lugin/src/rules/padding-line-between-statements.ts 93.83% <75.00%> (+2.92%) ⬆️
...eslint-plugin/src/rules/consistent-type-imports.ts 94.26% <93.33%> (+0.78%) ⬆️
...eslint-plugin/src/rules/consistent-type-exports.ts 97.70% <94.44%> (+1.86%) ⬆️
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 97.05% <100.00%> (+2.94%) ⬆️
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts 84.31% <100.00%> (+1.96%) ⬆️
...ckages/eslint-plugin/src/rules/no-throw-literal.ts 97.67% <100.00%> (+2.67%) ⬆️
... and 241 more

@armano2 armano2 changed the title test(parser): update parser tsx tests to not use eslint doc(website): update parser tsx tests to not use eslint Dec 18, 2021
@armano2 armano2 changed the title doc(website): update parser tsx tests to not use eslint docs(website): update parser tsx tests to not use eslint Dec 18, 2021
@armano2 armano2 changed the title docs(website): update parser tsx tests to not use eslint test(parser): update parser tsx tests to not use eslint Dec 18, 2021
bradzacher
bradzacher approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet LGTM

@bradzacher bradzacher merged commit b57aa90 into main Dec 20, 2021
@bradzacher bradzacher deleted the dep/remove-experimental-utils-from-parser-dep branch December 20, 2021 04:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

@armano2 armano2

Labels
package: parser Issues related to @typescript-eslint/parser tests anything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@armano2 @bradzacher