fix(eslint-plugin): [non-nullable-type-assertion-style] false-positiv…

…e with non-nullish `as` assertions and types (#3940)
typescript-eslint · Oct 3, 2021 · 40760f9 · 40760f9
1 parent c40dd13
commit 40760f9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/non-nullable-type-assertion-style.ts b/packages/eslint-plugin/src/rules/non-nullable-type-assertion-style.ts
@@ -57,6 +57,10 @@ export default util.createRule({
           type.flags !== ts.TypeFlags.Undefined,
       );
 
+      if (nonNullishOriginalTypes.length === originalTypes.length) {
+        return false;
+      }
+
       for (const assertedType of assertedTypes) {
         if (!nonNullishOriginalTypes.includes(assertedType)) {
           return false;

diff --git a/packages/eslint-plugin/tests/rules/non-nullable-type-assertion-style.test.ts b/packages/eslint-plugin/tests/rules/non-nullable-type-assertion-style.test.ts
@@ -54,6 +54,13 @@ const y = x as NonNullable<T>;
     `
 const foo = [] as const;
     `,
+    `
+const x = 1 as 1;
+    `,
+    `
+declare function foo<T = any>(): T;
+const bar = foo() as number;
+    `,
   ],
 
   invalid: [