fix(eslint-plugin): [no-confusing-void-expression] support optional c…

…haining (#3937)
typescript-eslint · Oct 3, 2021 · c40dd13 · c40dd13
1 parent 972e2c2
commit c40dd13
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-confusing-void-expression.ts b/packages/eslint-plugin/src/rules/no-confusing-void-expression.ts
@@ -268,6 +268,11 @@ export default util.createRule<Options, MessageId>({
         }
       }
 
+      if (parent.type === AST_NODE_TYPES.ChainExpression) {
+        // e.g. `console?.log('foo')`
+        return findInvalidAncestor(parent);
+      }
+
       // any other parent is invalid
       return parent;
     }

diff --git a/packages/eslint-plugin/tests/rules/no-confusing-void-expression.test.ts b/packages/eslint-plugin/tests/rules/no-confusing-void-expression.test.ts
@@ -27,6 +27,7 @@ ruleTester.run('no-confusing-void-expression', rule, {
         foo && console.log(foo);
         foo || console.log(foo);
         foo ? console.log(true) : console.log(false);
+        console?.log('foo');
       `,
     }),
 
@@ -61,6 +62,7 @@ ruleTester.run('no-confusing-void-expression', rule, {
     ...batchedSingleLineTests<MessageId, Options>({
       code: `
         const x = console.log('foo');
+        const x = console?.log('foo');
         console.error(console.log('foo'));
         [console.log('foo')];
         ({ x: console.log('foo') });
@@ -72,14 +74,15 @@ ruleTester.run('no-confusing-void-expression', rule, {
       `,
       errors: [
         { line: 2, column: 11, messageId: 'invalidVoidExpr' },
-        { line: 3, column: 23, messageId: 'invalidVoidExpr' },
-        { line: 4, column: 10, messageId: 'invalidVoidExpr' },
-        { line: 5, column: 15, messageId: 'invalidVoidExpr' },
-        { line: 6, column: 14, messageId: 'invalidVoidExpr' },
-        { line: 7, column: 9, messageId: 'invalidVoidExpr' },
-        { line: 8, column: 10, messageId: 'invalidVoidExpr' },
-        { line: 9, column: 18, messageId: 'invalidVoidExpr' },
-        { line: 10, column: 10, messageId: 'invalidVoidExpr' },
+        { line: 3, column: 19, messageId: 'invalidVoidExpr' },
+        { line: 4, column: 23, messageId: 'invalidVoidExpr' },
+        { line: 5, column: 10, messageId: 'invalidVoidExpr' },
+        { line: 6, column: 15, messageId: 'invalidVoidExpr' },
+        { line: 7, column: 14, messageId: 'invalidVoidExpr' },
+        { line: 8, column: 9, messageId: 'invalidVoidExpr' },
+        { line: 9, column: 10, messageId: 'invalidVoidExpr' },
+        { line: 10, column: 18, messageId: 'invalidVoidExpr' },
+        { line: 11, column: 10, messageId: 'invalidVoidExpr' },
       ],
     }),