Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#11721: Ignore .hypothesis #11722

Merged
merged 3 commits into from Oct 25, 2022
Merged

#11721: Ignore .hypothesis #11722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8490ae4
Ignore .hypothesis/
twm Oct 24, 2022
84404db
Enough of this nonsense
twm Oct 22, 2022
3636b41
Merge branch 'trunk' into 11721-dothypothesis
twm Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/check-pr-text.py
View file
Open in desktop
Expand Up @@ -41,7 +41,7 @@ def fail(message):
if not pr_body:
fail("Body for the PR not found. " "Maybe missing PR_BODY env var.")

title_search = re.search(r"^(#\d+) .+", pr_title)
title_search = re.search(r"^(#\d+):? .+", pr_title)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should also update the PR template to document that multiple title formats are allowed.

AFAIK, the PR template is the only documenting for our PR naming convention.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 I think that a bot should be maintaining this invariant, not human beings.

if not title_search:
fail(
"Title of PR has no issue ID reference. It must look like “#1234 Foo bar baz”."
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -21,3 +21,4 @@ pip-wheel-metadata/
.vscode/
.idea/
.tox/
.hypothesis/
Empty file added src/twisted/newsfragments/11721.misc
View file
Open in desktop
Empty file.