#11721: Ignore .hypothesis #11722
Merged
#11721: Ignore .hypothesis #11722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
twm
force-pushed
the
11721-dothypothesis
branch
from
579f461
to
84404db
Compare
adiroiban
approved these changes
Oct 24, 2022
| @@ -41,7 +41,7 @@ def fail(message): | |||
| if not pr_body: | |||
| fail("Body for the PR not found. " "Maybe missing PR_BODY env var.") | |||
|
|
|||
| title_search = re.search(r"^(#\d+) .+", pr_title) | |||
| title_search = re.search(r"^(#\d+):? .+", pr_title) | |||
There was a problem hiding this comment.
I think that we should also update the PR template to document that multiple title formats are allowed.
AFAIK, the PR template is the only documenting for our PR naming convention.
There was a problem hiding this comment.
🤷 I think that a bot should be maintaining this invariant, not human beings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #11721. See there for an exhaustive discussion.